Lints: add new lints for Mozilla Root Store Policy (adopted) #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mozilla Root Store Policy contains multiple different requirements on RSA keys. All these were tested in a single lint. These split into two different lints based on the different requirement.
Co-Authored-By: Daniel McCarney <daniel@binaryparadox.net>
Co-Authored-By: Daniel McCarney <daniel@binaryparadox.net>
Co-Authored-By: Daniel McCarney <daniel@binaryparadox.net>
Co-Authored-By: Daniel McCarney <daniel@binaryparadox.net>
Co-Authored-By: Daniel McCarney <daniel@binaryparadox.net>
Co-Authored-By: Daniel McCarney <daniel@binaryparadox.net>
Co-Authored-By: Daniel McCarney <daniel@binaryparadox.net>
added 9 commits
January 14, 2020 17:04
We'll return to this requirement in a subsequent PR when the tooling to generate the data can be reviewed and automated.
zakird
requested changes
Jan 15, 2020
|
I don't have a strong opinion given that there's a check above for whether
it applies.
…On Wed, Jan 15, 2020 at 8:20 AM Daniel McCarney ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lints/mozilla/lint_mp_authority_key_identifier_correct.go
<#353 (comment)>:
> +
+func (l *authorityKeyIdentifierCorrect) Initialize() error {
+ return nil
+}
+
+func (l *authorityKeyIdentifierCorrect) CheckApplies(c *x509.Certificate) bool {
+ return util.IsExtInCert(c, util.AuthkeyOID)
+}
+
+func (l *authorityKeyIdentifierCorrect) Execute(c *x509.Certificate) *lint.LintResult {
+ var keyID keyIdentifier
+
+ ext := util.GetExtFromCert(c, util.AuthkeyOID)
+ if ext == nil {
+ return &lint.LintResult{
+ Status: lint.Fatal,
I think I might have recommended being defensive in the event that Execute
is called with a cert that doesn't have the extension despite CheckApplies
checking it during my reviews of the original work. In retrospect that
doesn't seem worth it. I'll axe this check and leave a comment.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#353?email_source=notifications&email_token=AABREUHMORUGFJENGHVCSMLQ54ZURA5CNFSM4KHFT5UKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCR3QMMI#discussion_r366970883>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABREUHUGDR66EDIY24QGODQ54ZURANCNFSM4KHFT5UA>
.
|
This was referenced Jan 15, 2020
Yes, this is https://bugzilla.mozilla.org/show_bug.cgi?id=1586860 |
|
@sleevi Aha, thanks! I didn't think to check Bugzilla for overlap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated copy of #323 by @fotisl that addresses the outstanding review feedback.
It adds five new lints to the
lints/mozillapackage, specyfing the sourcelint.MozillaRootStorePolicyn_mp_allowed_ekue_mp_authority_key_identifier_correcte_mp_exponent_cannot_be_onee_mp_modulus_must_be_2048_bits_or_moree_mp_modulus_must_be_divisible_by_8Notable changes from #323:
e_mp_allowed_ekulint was changed to not rely on Mozilla trusted SPKI data (see Mozilla trusted roots data set and assoc. tooling #352 ) and so returns a notice level lint result instead of error since we accept it will have false positives in the current state.e_mp_ecdsa_allowed_algorithmlint and tests were removed. There was too much disagreement about the approach/description. We'll address this Mozilla requirement in a follow-up: Lint for Mozilla PKI policy allowed ECDSA curves #355To be done: