lints: lint for upcoming Apple max cert lifetime policy. #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new `e_tls_server_cert_valid_time_longer_than_398_days` lint is added for the Apple source category (presently named "AppleCTPolicy", see TODO in code). This lint returns an error lint result if a certificate issued after Sept 1st, 2020 has a lifetime > 398 days. A notice result is returned if a certificate issued after Sept 1st, 2020 has a lifetime > 397 days and < 398 days. This matches Apple's recommendation to use a validity period <= 397 days in length. See https://support.apple.com/en-us/HT211025 for more information.
sleevi
suggested changes
Mar 17, 2020
A comment is included to justify the rationale. This also better matches the name of the `warnEndDate` variable.
Thanks for the review @sleevi! I think it's ready for a second 🔍 when you have a chance. |
|
No need to block on me
…On Tue, Mar 17, 2020 at 8:51 AM sleevi ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks! Looks good, I wasn't sure if @zakird <https://github.com/zakird>
wanted to look but I think you've got it all.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#417 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABREUDM2MTWKUXGLUA4UF3RH6L67ANCNFSM4LF3FMMQ>
.
|
|
Thanks all. I'll update the PR description and squash merge it momentarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
e_tls_server_cert_valid_time_longer_than_398_dayslint is added for the Apple source category (presently namedlint.AppleCTPolicy, see #418).This lint returns an error lint result if a server-auth certificate issued after Sept 1st, 2020 has a lifetime > 398 days. The lifetime is calculated as Apple specifies, e.g. "398 days is measured with a day being equal to 86,400 seconds.".
A warning result is returned if a certificate issued after Sept 1st, 2020 has a lifetime > 397 days and < 398 days. This matches Apple's SHOULD-equivalent recommendation to use a validity period <= 397 days in length.
See https://support.apple.com/en-us/HT211025 for more information.
Resolves #407