Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gTLD map: capture 2020-04-01 removal of xn--estv75g #426

Closed
wants to merge 1 commit into from

Conversation

ezekiel
Copy link
Contributor

@ezekiel ezekiel commented Apr 2, 2020

No description provided.

@cpu
Copy link
Member

cpu commented Apr 2, 2020

👋 Thanks for the PR, but it's a duplicate of #425

@cpu cpu closed this Apr 2, 2020
@cpu
Copy link
Member

cpu commented Apr 2, 2020

One other thought: I think it would be better to let the @tld-update-bot open these PRs. That way we know for sure that no transliteration errors occurred between the upstream JSON and the committed diff. The bot runs every 24hrs at aproximately 1pm eastern time but if there's a situation that requires the new data be pulled in faster I think it would be better to open an issue instead of a PR and a maintainer can kick the bot. It's not likely to be any slower than opening a PR manually because those still require a maintainer to merge.

Hope that makes sense, thanks again for the PR!

@ezekiel ezekiel deleted the tld-removal branch April 2, 2020 20:42
@ezekiel
Copy link
Contributor Author

ezekiel commented Apr 2, 2020

Yep sounds good, we'll just open an issue if there's a need in the future. We'll keep the 24hr window in mind, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants