Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update goreleaser install URL. #429

Merged
merged 1 commit into from
May 11, 2020
Merged

Conversation

cpu
Copy link
Member

@cpu cpu commented May 11, 2020

The upstream project README is using a different URL now and in my tests the old URL has an HTTPS subject common name mismatch preventing installation from succeeding.

This is also manifesting as a broken master build in CI:

$ curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.21.0
curl: (22) The requested URL returned error: 404 Not Found

The upstream project README[0] is using a different URL now and in my
tests the old URL has an HTTPS subject common name mismatch preventing
installation from succeeding and breaking the `make code-lint` phase of
integration tests.

[0]: https://github.com/golangci/golangci-lint#install
@cpu cpu requested a review from zakird May 11, 2020 14:37
@cpu cpu self-assigned this May 11, 2020
@cpu cpu merged commit 1e160b1 into zmap:master May 11, 2020
@cpu cpu deleted the cpu-update-golangci-url branch May 11, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants