Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error message of ReadTestCert's panic #478

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Improve the error message of ReadTestCert's panic #478

merged 2 commits into from
Sep 25, 2020

Conversation

jdkasten
Copy link
Contributor

The error from x509.ParseCertificate was not being included within the panic.Debugging is easier if this information is retained.

@jdkasten
Improve error message of ReadTestCert panic
b207bfd 
The error from x509.ParseCertificate was not being included within the panic.Debugging is easier if this information is retained.
cpu
cpu approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs conflicts resolved, otherwise LGTM. Thanks!

@zakird zakird merged commit f7543c7 into zmap:master Sep 25, 2020
@jdkasten
Copy link
Contributor Author

Thanks for the merge, Zakir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@zakird zakird zakird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdkasten @zakird @cpu