No underscores are allowed in DNSNames after BR 1.6.2's permissibility period #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-henderson
changed the title
christopher-henderson
changed the title
sleevi
approved these changes
Feb 13, 2022
| Description: "DNSNames MUST NOT contain underscore characters", | ||
| Citation: "BR 7.1.4.2.1", | ||
| Source: lint.CABFBaselineRequirements, | ||
| EffectiveDate: util.BALLOT_SC_12_Ineffective, |
There was a problem hiding this comment.
I realize we're all over the board with dates, so this is very much a "nit" (and already the suggestion elsewhere to rename this, which I suppose this would replace), but wdyt about
CABFBRs_1_6_2_UnderscoreSunsetDate
It's very long, so it may be a terrible name though.
There was a problem hiding this comment.
The interesting thing about this repo and is that how often "breaking the rules" is actually the preferred option.
LintThisButOnlyWhenThatAndOnlyOnTheseDays
This is an awful name, but the alternative would be vague (at best) and most likely misleading.
In fact, I will see your long name and raise you a CABFBRs_1_6_2_UnderscorePermissibilitySunsetDate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint encodes that, post the brief permissibility period from December 10th 2018 to April 1st 2019, CABF BR does not permit the underscore character anywhere within DNS names.