-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Go 1.18 and update GolangCI Linter #672
Merged
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b4eeea1
upgrding the repo to Go 1.18
christopher-henderson 09fd871
go mod tidy
christopher-henderson 33dda7c
the linter is a bit much
christopher-henderson 4350256
adding the linter upgrade back into suss out the problem
christopher-henderson 145d8b5
I think we need to coerce the go installation
christopher-henderson 38505b0
I truly dislike this linter, it's not very good software
christopher-henderson 3c2e850
bump both gha action and software version for golancilinter
christopher-henderson 6be86de
forbidgo is useless
christopher-henderson 241d772
needs to be in the yaml file not the makefile
christopher-henderson 9c58919
confirming that the nolint directive actually works
christopher-henderson 6742c26
satisfy this picky eater of a lint
christopher-henderson aea300d
just no, these are awful suggestions
christopher-henderson b6b2395
disabling more
christopher-henderson ea17885
and more
christopher-henderson 44587d9
last one
christopher-henderson d657bad
Merge branch 'master' into go18update
christopher-henderson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,6 +33,7 @@ linters: | |
| - goconst | ||
| - golint | ||
| - godot | ||
| - forbidigo | ||
|
|
||
| issues: | ||
| exclude-rules: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| module github.com/zmap/zlint/v3/cmd/genTestCerts | ||
|
|
||
| go 1.18 | ||
|
|
||
| require ( | ||
| github.com/zmap/zcrypto v0.0.0-20210811211718-6f9bc4aff20f | ||
| github.com/zmap/zlint/v3 v3.0.0 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/weppos/publicsuffix-go v0.15.1-0.20210807195340-dc689ff0bb59 // indirect | ||
| golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83 // indirect | ||
| golang.org/x/net v0.0.0-20210226172049-e18ecbb05110 // indirect | ||
| golang.org/x/text v0.3.5 // indirect | ||
| gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect | ||
| ) | ||
|
|
||
| replace github.com/zmap/zlint/v3 => ../../ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,20 @@ | ||
| module github.com/zmap/zlint/v3 | ||
|
|
||
| require ( | ||
| github.com/kr/text v0.2.0 // indirect | ||
| github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect | ||
| github.com/sirupsen/logrus v1.8.1 | ||
| github.com/stretchr/testify v1.7.0 // indirect | ||
| github.com/zmap/zcrypto v0.0.0-20210811211718-6f9bc4aff20f | ||
| golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83 | ||
| golang.org/x/net v0.0.0-20210226172049-e18ecbb05110 | ||
| golang.org/x/sys v0.0.0-20210228012217-479acdf4ea46 // indirect | ||
| golang.org/x/text v0.3.5 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/kr/text v0.2.0 // indirect | ||
| github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect | ||
| github.com/stretchr/testify v1.7.0 // indirect | ||
| github.com/weppos/publicsuffix-go v0.15.1-0.20210807195340-dc689ff0bb59 // indirect | ||
| golang.org/x/sys v0.0.0-20210228012217-479acdf4ea46 // indirect | ||
| gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f // indirect | ||
| ) | ||
|
|
||
| go 1.16 | ||
| go 1.18 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forbidgois profoundly useless. It literally bans certain regexes from your codebase - notable any use offmt.Print(f|ln)(because I guess it's illegal to print to stdout without a logging framework?)