Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subject rdns correct encoding #824

Merged
merged 30 commits into from
Apr 14, 2024
Merged

Subject rdns correct encoding #824

merged 30 commits into from
Apr 14, 2024

Conversation

mtgag
Copy link
Contributor

@mtgag mtgag commented Apr 5, 2024

This PR addresses the proposal in PR #819, to have separate lints about the encoding of subject attributes as specified in BR 2.0.0.

mtg and others added 27 commits February 4, 2020 17:45
lint about the encoding of qcstatements for PSD2
6c23670
Revert "lint about the encoding of qcstatements for PSD2"
4666bb7 
This reverts commit 6c23670.
Merge https://github.com/zmap/zlint
01996c6
Merge https://github.com/zmap/zlint
28481cc
Merge https://github.com/zmap/zlint
749d896
@web-flow
util: gtld_map autopull updates for 2021-10-21T07:25:20 UTC
e56e2a0
@mtgag
Merge pull request #1 from mtgag/zlint-gtld-update
8600050 
util: gtld_map autopull updates for 2021-10-21T07:25:20 UTC
@mtgag
Merge https://github.com/zmap/zlint
30b096e
@mtgag
always check and perform the operation in the execution
92e659c
@christopher-henderson
Merge branch 'master' into master
351a379
@mtgag
Merge https://github.com/zmap/zlint
b52111b
@mtgag
Merge https://github.com/zmap/zlint
526f9be
@mtgag
Merge https://github.com/zmap/zlint
92902fc
@mtgag
synchronised with project
1652cfa
@mtgag
synchronised with project
d4f2f9f
@mtgag
Merge https://github.com/zmap/zlint
88c933e
@mtgag
Merge https://github.com/zmap/zlint
cee805f
@mtgag
synchronised with project
2408543
@mtgag
synchronised with project
67537e9
@mtgag
synchronised with project
e77fae1
@mtgag
synchronised with project
51d498f
@mtgag
Merge https://github.com/zmap/zlint
31e1845
@mtgag
Merge https://github.com/zmap/zlint
d10444e
@mtgag
fixed merge error
53b911e
@mtgag
Merge https://github.com/zmap/zlint
f1a66db
@mtgag
Merge https://github.com/zmap/zlint
795d206
@mtgag
synchronised with project
bad73ee
@mtgag mtgag mentioned this pull request Apr 5, 2024
Closed
@christopher-henderson christopher-henderson self-requested a review April 6, 2024 15:10
christopher-henderson
christopher-henderson reviewed Apr 6, 2024
View reviewed changes
Copy link
Member

@christopher-henderson christopher-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I think we should wait until the release of 3.6.2 since CAs seems to have been operating for years just fine without this.

@mtgag
Copy link
Contributor Author

mtgag commented Apr 7, 2024

This looks good, but I think we should wait until the release of 3.6.2 since CAs seems to have been operating for years just fine without this.

Yes, we can put it on hold until and wait for the proper release.

@christopher-henderson christopher-henderson merged commit 5de620c into zmap:master Apr 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopher-henderson christopher-henderson christopher-henderson left review comments

@dadrian dadrian dadrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtgag @dadrian @christopher-henderson @web-flow