Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout with client id parameter #518

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

patryk-sob
Copy link

Logout with client_id parameter is allowed due to openid specification. When id_token_hint is not specified, client_id can be used instead. This change is a solution for situation when session_token is expired and in the logout operation we get the error message "Missing Parameters: id_token_hint error on Session timeout.".

Logout with client_id parameter is allowed due to openid specification. When id_token_hint is not specified, client_id can be used instead. This change is a solution for situation when session_token is expired and in the logout operation we get the error message "Missing Parameters: id_token_hint error on Session timeout.".
@patryk-sob patryk-sob marked this pull request as ready for review June 10, 2024 12:23
@patryk-sob
Copy link
Author

@bodewig
Copy link
Collaborator

bodewig commented Aug 25, 2024

could you please add a new configuration param like redirect_after_logout_with_id_token_hint for this and document it? Bonus points for extending https://github.com/zmartzone/lua-resty-openidc/blob/master/tests/spec/logout_spec.lua ;-)

- Implementation of logout with client_id parameter instead of id_token_hint parameter (openidc.lua)
- New test scenario for logout with client_id parameter (logout_spec.lua)
- Document new configuration parameter redirect_after_logout_with_client_id (README.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants