Enable caching of negative introspection responses #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the point about a negative cache but it does open up for resource exhaustion attacks: it should at least be configurable, with the default set to "off" and a warning about the former in the docs |
|
@zandbelt You are right. I will try to rework this a bit to update both documentation and configuration options :) |
|
@zandbelt I've updated this PR to address your comments. Please let me know what do you think about it. |
|
@zandbelt Is there anything else I have to do to be able to merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now every single introspection response which has
activefield not set totrueis just rejected. In situation where there are multiple calls using the same expired/revoked/wrong token response from introspection endpoint could be cached for time set inexpfield.This change will allow to do so. By simple configuration in introspection service it will be possible to enable or not (by setting proper value to
expfield) caching of responses for inactive tokens.