Bluetooth: GATT: Fix BT_GATT_AUTO_DISCOVER_CCC #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using BT_GATT_AUTO_DISCOVER_CCC if the ccc_handle is not set bt_gatt_subscribe would initiate a discovery to locate the CCC handle but instead of awaiting it to complete the code does proceed to call gatt_write_ccc even with ccc_handle being 0x0000 which is invalid. Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> (cherry picked from commit 64cc5a3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of a Zephyr
masterfix for auto discover of GATT CCC descriptors when subscribing for notifications/indications. I'm using this for the cleaned up code in zmkfirmware/zmk#547 that @joelspadin noted. By adding this, we can avoid doing a bunch of extra discovery tracking ourselves, and let Zephyr stack handle it.When using BT_GATT_AUTO_DISCOVER_CCC if the ccc_handle is not set
bt_gatt_subscribe would initiate a discovery to locate the CCC handle
but instead of awaiting it to complete the code does proceed to call
gatt_write_ccc even with ccc_handle being 0x0000 which is invalid.
Signed-off-by: Luiz Augusto von Dentz luiz.von.dentz@intel.com
(cherry picked from commit 64cc5a3)