improve: Key Component scale transition #108
Conversation
✅ Deploy Preview for zmk-studio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pongstr
force-pushed
the
refactor-key-component
branch
2 times, most recently
from
7d133d6 to
e40af6e
Compare
pongstr
force-pushed
the
refactor-key-component
branch
from
e40af6e to
2669d02
Compare
There was a problem hiding this comment.
The UI itself seems way better! See my one code comment, but I'm optimistic about this. I'm not sure about the willChange tweak, given that did improve the rendering for some folks, so I'm uncertain about that particular tweak without broader testing/feedback across more browsers/platforms.
pongstr
force-pushed
the
refactor-key-component
branch
from
2669d02 to
55f5f8e
Compare
- improve: smoother scale transition when hovering - feat: toggle select+deselect, allows users to deselect a currently selected key .
pongstr
force-pushed
the
refactor-key-component
branch
from
55f5f8e to
e3ff99c
Compare
I've tested this proposal on
the improvements are apparent, i'll test both on my Debian machine tomorrow. btw, it'd be nice if PR can also have desktop-app build pipeline to make proposals accessible for testing, setting up tauri on windows is quite laborious 😄 Anyway, let me know if there's anything else I can do to get this PR to move forward. Thanks! |
| > | ||
| {header && ( | ||
| <span className="p-0 b-0 m-0 text-xs w-full h-full text-nowrap justify-self-start row-start-1 row-end-2 col-start-1 col-end-4 hidden group-hover:inline-block group-hover:truncate @md:underline"> | ||
| <span className="w-9/12 absolute text-micro top-1 left-1 right-1 leading-none text-cemter group-hover:block uppercase h-4 hidden truncate whitespace-nowrap"> |
Storybook before+after
Before.mov
After.mov
desktop build (macos)
Screen.Recording.2024-12-12.at.15.39.47.mov