-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Send mouse scroll events from encoder rotations, instead of page up/down #72
Comments
Would this feature also include general implementation of mouse keys? |
This and mouse keys would both rely on some of the same underlying HID changes needed, but would be implemented slightly differently, likely. However, there is distinct API for behaviours reacting to key positions versus sensor events, so we could choice to use one behavior for both if we wanted. |
Hi all, are there any advances on this request? If there is some test code I would like to try it. |
I was able to leverage what was in Nick's repo: Happy to try to submit a PR but I have very limited knowledge here and don't want to mess something up |
Trying to make this work on the new PR (#2027) as well as on top of Nick's repo (linked by @t4corun above), but the scroll wheel binding does not seem to work for me.. Here's the behavior I'm using
then it's defined in the keymap:
I'm obviously missing something, as the scroll works when mapped to a key, but does not work when mapped to the encoder. |
It is probable that the scrolling signal sent isn't enough for the computer to translate to an actual scroll, since the duration that encoder sends a tap event is very short by default. If that isn't enough to scroll, you might want to increase the max speed of the scroll behavior; e.g. define a larger |
Thanks for the help! Had to both to make it work: |
I think this has been completed in #2477. |
It sort of has sort of hasn't I think - the capability exists, but in a roundabout manner rather than the direct one that would be desired. |
Given encoders use sensor-rotate behaviors and they use regular behaviors as bindings and mouse scroll is currently implemented as a regular behavior, I don't see an alternate implementation that is more directly tied to encoders. We should probably document this as an example though, since the |
I recall some discussion on moving encoders to the input API, which is what I was referring to. I wouldn't be opposed to closing this issue and opening one which asks about moving them to the input API though. Agree on example. |
I guess I'll close, as the OP Pete can reopen if he wants to. |
Sending page up/down on encoder rotation only supports scrolling the actively focused content on most OSes. If we instead were to expose a HID mouse/trackpad, and send vertical scroll events, the experience may be improved for many scenarios.
The text was updated successfully, but these errors were encountered: