fix(behaviors): allow saving sticky keys with the same position #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `position` was used to search for a sticky key, but it was not sufficient because keys with different layers or generated by macros could have the same position. This caused issues when saving keys with the same position, as only one could be saved at a time. Adding checks on `param1`, `position`, and `layer` resolves the issue, but `param1` alone is sufficient to identify sticky keys.
|
This... Seems like a fairly reasonable fix for this. Let me consider if there's any potential downsides to this approach. @okke-formsma any concerns? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sticky key is pressed, a duplicated sticky key will be searched for and released. However, currently only
positionis used to search for a sticky key, which causes issues because keys with different layers may have the same position.Adding checks on both
positionandlayeris not enough because key events generated by macro have the same position and layer.7a4f3a2
I have been considering that two sticky keys
&sk LEFT_SHIFTat different positions should be treated as the same sticky key. The use ofpositionorlayeris not necessary becauseparam1has keycode, usage page, and mods, which are sufficient to identify sticky keys.Fix #1421