-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sofle: add underglow support with &pinctrl
update
#1854
sofle: add underglow support with &pinctrl
update
#1854
Conversation
It might make sense to add the commented out underglow options to https://github.com/zmkfirmware/zmk/blob/main/app/boards/shields/sofle/sofle.conf, similar to other shields like https://github.com/zmkfirmware/zmk/blob/main/app/boards/shields/corne/corne.conf. |
894bf62
to
5007a6e
Compare
Good call. Added. |
Thanks! Can you also add a duplicate |
5007a6e
to
cb575f7
Compare
I had wondered about that, myself. Done. |
Thanks, LGTM. |
Just realized while digging through PRs for another Sofle-related issue that this work had already been done more than a year ago: #1188 Any idea how we can get that merged? |
cb575f7
to
cb760b4
Compare
&led_strip
support&pinctrl
update
Another person on Discord ran into the missing underglow support for the Sofle. In this PR I have now rebased #1188 and applied the |
Update sofle underglow to zephyr 3
cb760b4
to
0f6092b
Compare
built using this fork and it worked as expected: https://github.com/SMQuazi/zmk-config Both underglow and per key LEDs worked. |
0f6092b
to
f82ddba
Compare
Sofle users continue to run into issues that would not have occurred if these changes had been merged. These changes are now over a year and a half old and have been successfully used by many people. Can we please get this merged? |
On behalf of illuminated Sofle users yet to come, thank you @petejohanson! And thank you @infused-kim for doing all of the heavy lifting on this in #1188! |
Multiple folks on the ZMK Discord server have recently run into difficulties trying to get RGB underglow working on their Sofle, as a result of mainline Sofle not having
&led_strip
defined. Thisnice_nano_v2.overlay
—similar to overlays for other boards (differing only in defaultchain-length
)—should be sufficient to remove this hurdle for others.