Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sofle: add underglow support with &pinctrl update #1854

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

SethMilliken
Copy link
Contributor

Multiple folks on the ZMK Discord server have recently run into difficulties trying to get RGB underglow working on their Sofle, as a result of mainline Sofle not having &led_strip defined. This nice_nano_v2.overlay—similar to overlays for other boards (differing only in default chain-length)—should be sufficient to remove this hurdle for others.

@caksoylar
Copy link
Contributor

@SethMilliken SethMilliken force-pushed the sofle-led-strip-support branch from 894bf62 to 5007a6e Compare July 1, 2023 23:45
@SethMilliken
Copy link
Contributor Author

It might make sense to add the commented out underglow options to https://github.com/zmkfirmware/zmk/blob/main/app/boards/shields/sofle/sofle.conf, similar to other shields

Good call. Added.

@caksoylar
Copy link
Contributor

Thanks! Can you also add a duplicate nice_nano.overlay? While we are not very consistent on adding an overlay for every compatible board, we seem to be consistent in supporting both versions if we support one, at the moment.

@SethMilliken SethMilliken force-pushed the sofle-led-strip-support branch from 5007a6e to cb575f7 Compare July 1, 2023 23:51
@SethMilliken
Copy link
Contributor Author

Thanks! Can you also add a duplicate nice_nano.overlay? While we are not very consistent on adding an overlay for every compatible board, we seem to be consistent in supporting both versions if we support one, at the moment.

I had wondered about that, myself. Done.

@caksoylar
Copy link
Contributor

Thanks, LGTM.

@SethMilliken
Copy link
Contributor Author

Just realized while digging through PRs for another Sofle-related issue that this work had already been done more than a year ago: #1188

Any idea how we can get that merged?

@caksoylar caksoylar requested a review from petejohanson July 23, 2023 04:16
@SethMilliken SethMilliken force-pushed the sofle-led-strip-support branch from cb575f7 to cb760b4 Compare September 1, 2023 00:25
@SethMilliken SethMilliken changed the title sofle: add &led_strip support sofle: add underglow support with &pinctrl update Sep 1, 2023
@SethMilliken
Copy link
Contributor Author

SethMilliken commented Sep 1, 2023

Another person on Discord ran into the missing underglow support for the Sofle.

In this PR I have now rebased #1188 and applied the &pinctrl updates to the overlay files.

@SethMilliken SethMilliken force-pushed the sofle-led-strip-support branch from cb760b4 to 0f6092b Compare September 1, 2023 00:35
@SMQuazi
Copy link

SMQuazi commented Sep 1, 2023

built using this fork and it worked as expected: https://github.com/SMQuazi/zmk-config

Both underglow and per key LEDs worked.

app/boards/shields/sofle/sofle.keymap Outdated Show resolved Hide resolved
@SethMilliken SethMilliken force-pushed the sofle-led-strip-support branch from 0f6092b to f82ddba Compare September 2, 2023 05:31
@SethMilliken
Copy link
Contributor Author

Sofle users continue to run into issues that would not have occurred if these changes had been merged. These changes are now over a year and a half old and have been successfully used by many people. Can we please get this merged?

@SethMilliken
Copy link
Contributor Author

On behalf of illuminated Sofle users yet to come, thank you @petejohanson! And thank you @infused-kim for doing all of the heavy lifting on this in #1188!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants