LED Indicators (bortoz work with minor fixes) #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
added
enhancement
petejohanson
force-pushed
the
led-indicators
branch
from
ab69346
to
f14ac2b
Compare
caksoylar
reviewed
Nov 27, 2023
| | `CONFIG_ZMK_HID_CONSUMER_REPORT_SIZE` | int | Number of consumer keys simultaneously reportable | 6 | | ||
| | Config | Type | Description | Default | | ||
| | ------------------------------------- | ---- | -------------------------------------------------------------- | ------- | | ||
| | `CONFIG_ZMK_HID_INDICATORS` | bool | Enable reciept of HID/LED indicator state from connected hosts | n | |
There was a problem hiding this comment.
Suggested change
| | `CONFIG_ZMK_HID_INDICATORS` | bool | Enable reciept of HID/LED indicator state from connected hosts | n | | |
| | `CONFIG_ZMK_HID_INDICATORS` | bool | Enable receipt of HID/LED indicator state from connected hosts | n | |
Is there a reason not to default this to on?
There was a problem hiding this comment.
After the USB BOOT work caused some unexpected issues (for you even), I'm wary to enable this by default until the actual version merged into ZMK main gets a bit more extensive testing by folks.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR to follow up on some fixed identified as needed in #999. Thanks so much to @bortoz for sticking with this for 2 whole years. Hoping to help get this across the finish line without wasting any more of their time.
In particular:
mainand integrate the HID defines added in refactor(hid): Use proper defines for HID values. #1993zmk_hid_indicators.