fix: Optimize layout changes by doing runtime mapping #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
petejohanson
commented
Oct 17, 2024
petejohanson
commented
- To avoid tons of migration, extra flash writes, etc, we keep the keymaps and settings using a key position index that's tied to the stock layout, and at runtime mapping key positions as needed.
petejohanson
added
enhancement
petejohanson
force-pushed
the
core/physical-layout-remapping-integration
branch
from
f728532
to
b431edc
Compare
joelspadin
reviewed
Oct 17, 2024
| @@ -247,12 +257,27 @@ int zmk_keymap_set_layer_binding_at_idx(zmk_keymap_layer_id_t layer_id, uint8_t | |||
|
|
|||
| ASSERT_LAYER_VAL(layer_id, -EINVAL) | |||
|
|
|||
| uint32_t *pos_map; | |||
| int ret = zmk_physical_layouts_get_selected_to_stock_position_map(&pos_map); | |||
| if (ret < 0) { | |||
There was a problem hiding this comment.
This case isn't currently possible. Will it ever be possible?
There was a problem hiding this comment.
Rather than change the API later, I wanted to ensure we guard now in case things change later with how position maps get created.
petejohanson
force-pushed
the
core/physical-layout-remapping-integration
branch
2 times, most recently
from
19fe334
to
b5e6f31
Compare
petejohanson
force-pushed
the
core/physical-layout-remapping-integration
branch
from
b5e6f31
to
5e0b167
Compare
* To avoid tons of migration, extra flash writes, etc, we keep the keymaps and settings using a key position index that's tied to the stock layout, and at runtime mapping key positions as needed.
petejohanson
force-pushed
the
core/physical-layout-remapping-integration
branch
from
5e0b167
to
130276e
Compare
|
Have tested this on a 75% with a split backspace layout, and on my revxlp, no issues. Also had testing on BakenekoGo with two layouts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.