Fix connection to incorrect peripheral #318
Conversation
Nicell
added
bluetooth
| LOG_ERR("Unable to load UUID"); | ||
| continue; | ||
| } | ||
|
|
||
| if (!bt_uuid_cmp(&uuid, BT_UUID_DECLARE_128(ZMK_SPLIT_BT_SERVICE_UUID))) { | ||
| if (bt_uuid_cmp(&uuid.uuid, BT_UUID_DECLARE_128(ZMK_SPLIT_BT_SERVICE_UUID))) { |
There was a problem hiding this comment.
I'm really not sure I agree with this. We want to be connecting to this discovered peripheral only if we found a UUID advertised the matches the ZMK split service UUID. That means these UUIDs need to be equal, which is why we're negating the result of bt_uuid_cmp. Help me see what I'm missing here?
There was a problem hiding this comment.
See here. When the two UUIDs match, it returns 0 or false. When you negate this, we now run this code whenever the two UUIDs match, which from what I'm reading is the opposite of what we want. Maybe an explicit != 0 (is not the same) would be easier to read?
There was a problem hiding this comment.
oh! I'm sorry, I should have read this more carefully. This fix does make sense.
There was a problem hiding this comment.
@xudongzheng Tested here locally, working great. Thanks for the fix!
I believe the check should be
if (bt_uuid_cmp(...))sincebt_uuid_cmp()returns "true" when the UUID is different. Allocatingstruct bt_uuid_128ensures that memory is correctly allocated for the custom UUID.