feat(ext-power): Cut power when PM is sleeping #417
Conversation
Nicell
force-pushed
the
ext-power/device-sleep
branch
from
a13ba95
to
07a550c
Compare
Nicell
added
core
Nicell
force-pushed
the
ext-power/device-sleep
branch
from
07a550c
to
19729e8
Compare
Nicell
force-pushed
the
ext-power/device-sleep
branch
2 times, most recently
from
ea24617
to
d9cda27
Compare
Nicell
force-pushed
the
ext-power/device-sleep
branch
from
d9cda27
to
49503eb
Compare
There was a problem hiding this comment.
This looks OK on the face of it, but I don't know this part of the system yet (and I can't test it), so I'm going to assign it to @petejohanson.
| switch (ctrl_command) { | ||
| case DEVICE_PM_SET_POWER_STATE: | ||
| if (*((uint32_t *)context) == DEVICE_PM_ACTIVE_STATE) { | ||
| data->pm_state = DEVICE_PM_ACTIVE_STATE; |
There was a problem hiding this comment.
Shouldn't this also be calling ext_power_generic_enable?
There was a problem hiding this comment.
Not in this case. When the device turns back on from sleep, the ext_power device is restarted and will automatically turn ext power back to its last saved state from settings. When we disable before going to sleep, that off state isn't saved in settings, so we'll properly retrieve the last state.
If we explicitly enabled here, people's power cut offs would turn back on whenever they wake up and get saved that way.
There was a problem hiding this comment.
My point is, when we add per-device power state management, we will want to cut/restore power state based on idle/active.
So we'll need an API for "on/off" that isn't state persisting. So we can call that from here.
Doesn't need to be this PR, so I'm going to approve for now.
We also need to consider that other devices may say "no, don't sleep now!" and abort the sleep state change, I believe.
There was a problem hiding this comment.
Approved, with the knowledge that this is a first step.
Thanks @Nicell!
| static int ext_power_generic_pm_control(const struct device *dev, uint32_t ctrl_command, | ||
| void *context, device_pm_cb cb, void *arg) { | ||
| int rc; | ||
| struct ext_power_generic_data *data = dev->driver_data; |
There was a problem hiding this comment.
This looks like the Zephyr 2.3.0 API. Was this tested with 2.4.0?
This adds support for cutting ext-power when the power management policy is set to low power using the central Zephyr device power management system.