-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shield): Add A. Dux shield #951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few initial comments, thanks!
9437ea6
to
79d51a9
Compare
Thanks @petejohanson, I've updated the PR based on your comments. 👍 |
Would it be worth keeping the machine name |
Given most of the conversations on the LPK have always used the shorthand, and the QMK naming is also doing so, I'm leaning towards agreeing w/ this. And indeed, much easier to type as needed if editing build.yml files, etc. Thoughts @dxmh? |
Thanks @caksoylar, @petejohanson - using the short name for user-friendliness is an excellent point. I've just updated the PR so the shield now uses |
The shorter name is more user-friendly.
4bc7261
to
261ade1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more minor fix found while verifying the metadata work.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds a new shield for Architeuthis Dux by Tapi (aka A. Dux, A.D., "Giant squid").
The shield has been available at
dxmh/zmk-architeuthis-dux
for a couple of months already, but it would be great for Architeuthis Dux to be supported in ZMK properly.