Add Bluehand Macropad - locally tested #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is it possible to add the hacktoberfest-accepted label? https://hacktoberfest.digitalocean.com/resources/participation |
Nicell
added
enhancement
|
Most of the checks seem to have failed due to docker pull issues: |
Nicell
requested changes
Oct 10, 2021
| @@ -0,0 +1,6 @@ | |||
| if SHIELD_BLUEHAND | |||
Comment on lines
1
to
3
| # Copyright (c) 2021 Mike "KemoNine" Crosson | ||
| # Copyright (c) 2021 jpconstantineau | ||
| # Copyright (c) 2021 DonPavlov |
There was a problem hiding this comment.
Generally, we're using the # Copyright (c) 2021 The ZMK Contributors format to ease copyright troubles in the future. Did these first two write this definition with you?
Comment on lines
1
to
3
| # Turn on deep sleep | ||
| # CONFIG_ZMK_SLEEP=y | ||
| # CONFIG_ZMK_IDLE_SLEEP_TIMEOUT=900000 |
There was a problem hiding this comment.
These options should be left out, as they are user-based configs whose default might change in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Board/Shield Check-list
.zmk.ymlmetadata file added&pro_microused in favor of&pro_micro_d/aif applicable.conffile has optional extra features commented outAdding Bluehand Macropad, now including .zmk.yml metadata file
tested the build worked with the command:
west build -p -b bluemicro840_v1 -- -DSHIELD=bluehand