-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output latency #829
base: master
Are you sure you want to change the base?
Add output latency #829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 2x comments added, besides
- follows the library standards for checking the plaform
- adds typescript type
- works :)
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "react-native-sound", | |||
"version": "0.11.2", | |||
"version": "0.11.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This I would leave to the maintainer to decide
@@ -196,7 +206,7 @@ declare class Sound { | |||
/** | |||
* Whether the player is playing or not. | |||
*/ | |||
isPlaying(): boolean | |||
isPlaying(): boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant
Adds the method getOutputLatency(callback: LatencyCallback): void. This method can be used to retrieve the current output latency of the AVAudioSession.