Skip to content

Commit

Permalink
Bump recommended Go development version in README
Browse files Browse the repository at this point in the history
[sigstore#568](sigstore#568) bumps the Go version
for tests to 1.17. Now they break for 1.16:

```sh
TMPDIR=$(mktemp -d)
cd $TMPDIR
git clone https://github.com/sigstore/cosign 2> /dev/null
cd cosign

for go in go_1_16 go_1_17; do
  nix-shell \
    -p ${go} \
    -p gnumake \
    --command 'make test' \
    > /dev/null 2>&1
  if [ $? -eq 0 ]; then
    echo ${go} good
  else
    echo ${go} bad
  fi
done
```

[sigstore#1252](sigstore#1252) adds a call to
`testing.T.Setenv`, added in
[1.17](https://go-review.googlesource.com/c/go/+/326790/3/api/go1.17.txt),
which caused this breakage.

(We're still testing *builds* on 1.16, so that's fine.)

Signed-off-by: Zachary Newman <z@znewman.net>
  • Loading branch information
znewman01 committed Jan 19, 2022
1 parent b0e81eb commit 84b3602
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ For Linux and macOS binaries see the [GitHub release assets](https://github.com/

## Developer Installation

If you have Go 1.16+, you can setup a development environment:
If you have Go 1.17+, you can setup a development environment:

$ git clone https://github.com/sigstore/cosign
$ cd cosign
Expand Down

0 comments on commit 84b3602

Please sign in to comment.