Remove unitstripswarnings #3
Conversation
andrewgsavage
changed the title
|
This should remove most Unitstripwarnings. There's none in the documentation at least! Any thoughts @znicholls ? Unitstripwarnings notes They're thrown whenever a method named _array* is called on a quantity. I've been either avoiding doing this (eg by going to quantity.magnitude) or using with warnings filtered when the warnings won't be an issue. That being said there's still a few cases where the warning is raised without going through the PintArray, so might need to look at changing how/when the warning is raised. |
|
@andrewgsavage to get tests passing again see andrewgsavage#4 |
|
Otherwise I'd rather not silence UnitStripWarnings in the tests, let's leave them if they're there |
Get tests passing again
| @@ -146,7 +147,35 @@ class TestInterface(base.BaseInterfaceTests): | |||
| pass | |||
|
|
|||
| class TestMethods(base.BaseMethodsTests): | |||
| pass | |||
|
|
|||
| @pytest.mark.filterwarnings("ignore::pint.UnitStrippedWarning") | |||
There was a problem hiding this comment.
I'd like to keep these warnings popping up unless there's a good reason to silence them?
There was a problem hiding this comment.
The ones I've been silencing should be occurring without going through the PintArray, so there's nothing we can do in pint_array.py to get rid of them - That'd have to be done in quantity.py.
Main reason I'd been silencing them was to get through them all easier. I think it's easier to spot whether a future change starts creating a UnitStrippedWarning like this.
I'm not fussed either way.
There was a problem hiding this comment.
ah ok makes sense, if they're not an issue then we leave it for now
|
|
||
| self.assert_series_equal(result, expected) | ||
|
|
||
| @pytest.mark.filterwarnings("ignore::pint.UnitStrippedWarning") |
There was a problem hiding this comment.
I'd like to keep these warnings popping up unless there's a good reason to silence them?
| @@ -275,8 +304,25 @@ class TestReshaping(base.BaseReshapingTests): | |||
| pass | |||
|
|
|||
| class TestSetitem(base.BaseSetitemTests): | |||
| pass | |||
| @pytest.mark.parametrize('setter', ['loc', None]) | |||
| @pytest.mark.filterwarnings("ignore::pint.UnitStrippedWarning") | |||
There was a problem hiding this comment.
I'd like to keep these warnings popping up unless there's a good reason to silence them?
| @@ -334,10 +380,15 @@ def test_pintarray_creation(self): | |||
| for y in ys: | |||
| self.assertQuantityAlmostEqual(x,y.data) | |||
|
|
|||
|
|
|||
| @pytest.mark.filterwarnings("ignore::pint.UnitStrippedWarning") | |||
There was a problem hiding this comment.
I'd like to keep these warnings popping up unless there's a good reason to silence them?
|
So is this OK to merge then? |
|
yep sorry |
|
Does it's time to get this into pint then? Exciting! |
ya |
Lazy way to get tests going again