Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local notifications on Android O #657

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Conversation

gustavogenovese
Copy link
Contributor

This fixes issue #606

@piu130
Copy link

piu130 commented Mar 4, 2018

@gcesarmza How did you solve the compile problem using a different version of appcompat v7?

react-native uses 23.0.1 and this project 26.0.+.

I get the following error:

Error:Execution failed for task ':app:preDebugBuild'.
> Android dependency 'com.android.support:appcompat-v7' has different version for the compile (23.0.1) and runtime (26.0.2) classpath. You should manually set the same version via DependencyResolution

@sheydarezaee
Copy link

sheydarezaee commented Mar 6, 2018

thanks @gcesarmza for your recent update on Android Oreo support .. I used your latest commit and now I am able to receive notifications, but app crashes upon receiving notifications. I tested this when app is closed. any resolution on that?

@piu130
Copy link

piu130 commented Mar 23, 2018

@sheydarezaee I think I found the problem. The default react-native config overrides allprojects.repositories in android/build.gradle so this module can only use mavenLocal(), jcenter() and maven { url "$rootDir/../node_modules/react-native/android" }. But there is only appcompat version 26-alpha1 available then.

So you have to add maven { url 'https://maven.google.com' } to allprojects.repositories in android/build.gradle to get newer appcompat versionsthat support NotificationChannel.

@elieteyssedou
Copy link

Is this pull request ready to be merged ? If so, could we have this fix in a new version of this package ? @zo0r

I think that Android 8 (Oreo) support is important.

@elieteyssedou
Copy link

I have tested it and it seems to work fine for me.

@calcazar
Copy link

FYI, I added your PR to a community edition clone I created for better support:

https://github.com/calcazar/react-native-push-notification-CE

@lordress
Copy link

Tested for local notification. Working fine on oreo.
Thanks!

@greyvugrin
Copy link

Confirmed that this fixes the issue too. @zo0r is this PR good to go? Other peeps - is there anyone else that can be pinged to bump this PR up?

@billdozr
Copy link

This is really becoming an issue:

40124759-29f9a924-5921-11e8-9e28-593dcf10caca

Any updates on getting this PR merged?

@gongmingqm10
Copy link

@gcesarmza Could you please help to resolve the conflicts for this PR.

@zo0r Please have a look at this Android O notification channel issue.

@1Jesper1
Copy link

Any plans for a new release on npm to fix this?

@Gp2mv3
Copy link
Contributor

Gp2mv3 commented Jul 13, 2018

Yes, after everything is tested and proven working.

@KemikalGeneral
Copy link

Hi! sorry, bit late to the party it seems, but i have recently joined a company that is using this package for push notifications and we too have the Android 8 issue of not receiving notifications.

It seems there have been a number of changes in recent months and as there are a lot of open issues regarding this and talk of soon to be pushed patches, i was wondering if there is a fix for it at all please?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.