Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requestPermissions crash (Issue #803) #809

Merged
merged 3 commits into from
Aug 10, 2018
Merged

Fix requestPermissions crash (Issue #803) #809

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a529d01
Fix requestPermission crash
Gp2mv3 Aug 1, 2018
2c4fcc9
Add import for symbol Log
lsirdevan Aug 2, 2018
dc03edc
Merge pull request #811 from logan1220/sdk26
Gp2mv3 Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
import java.util.Map;
import java.util.Random;

import android.util.Log;

import com.google.firebase.messaging.FirebaseMessaging;

public class RNPushNotification extends ReactContextBaseJavaModule implements ActivityEventListener {
Expand Down Expand Up @@ -130,8 +132,12 @@ public void requestPermissions(String senderID) {

Intent GCMService = new Intent(reactContext, RNPushNotificationRegistrationService.class);

GCMService.putExtra("senderID", senderID);
reactContext.startService(GCMService);
try {
GCMService.putExtra("senderID", senderID);
reactContext.startService(GCMService);
} catch (Exception e) {
Log.d("EXCEPTION SERVICE::::::", "requestPermissions: " + e);
}
}

@ReactMethod
Expand Down