-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the "old" GCM listener to get compatibility with GCM back #835
Conversation
@Gp2mv3 When I install version 3.1.1 through npm or yarn |
Hi @Gp2mv3. Any insights on my above question? |
It still crashes for me when receiving a GCM push notification. I'm using the latest commit containing this PR ( |
@silentlight with: & yarn install :) |
I'm with @stpch, I'm still crashing when receiving notifications while app is in the foreground. Have this branch checked out even:
|
It would appear that the firebase and GCM dependencies in build.gradle cannot coexist:
after deleting the firebase entry and any classes that depend on it I was able to rebuild and no more crashes. Looks like forking and reverting #717 is the only option to support GCM. Note: GCM is 100% deprecated, only do this if you know what you're doing and why. |
Maybe not the best solution in term of code redundancy but it works.
What do you think ?