Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3 Fix style preprocessing with Svelte versions 3.30.0 and beyond #4

Merged
merged 1 commit into from
Jul 23, 2021
Merged

#3 Fix style preprocessing with Svelte versions 3.30.0 and beyond #4

merged 1 commit into from
Jul 23, 2021

Conversation

arggh
Copy link

@arggh arggh commented Jul 23, 2021

Style preprocessor's return value's property code should hold just the CSS string, not the full result from PostCSS. This fixed implementation works with both 3.30.0+ and earlier versions of Svelte.

Things broke when Svelte hit 3.30.0 (sveltejs/svelte#5584), changing style preprocessor flow by introducing sourcemap support.

Fixes #3

Fix zodern#8
b2cdc53 
Return value object's property `code` should hold just the CSS string. This implementation works with both 3.30.0+ and earlier versions of Svelte.
@arggh arggh mentioned this pull request Jul 23, 2021
Closed
@zodern
Copy link
Owner

zodern commented Jul 23, 2021

Thanks @arggh

@zodern zodern merged commit 714f7e6 into zodern:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PostCSS preprocessing breaks with Svelte versions 3.30.0+
2 participants
@arggh @zodern