Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/accepter optional #28

Merged
merged 4 commits into from
Dec 17, 2019
Merged

Feature/accepter optional #28

merged 4 commits into from
Dec 17, 2019

Conversation

Geartrixy
Copy link
Contributor

#27 Make "aws_ram_resource_share_accepter" optional

@Geartrixy Geartrixy requested a review from soner89 December 17, 2019 13:03
soner89
soner89 approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@soner89 soner89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! According to the developer, this was tested successfully. I don't see anything which looks faulty.

README.md Outdated Show resolved Hide resolved
@Geartrixy @soner89
Update README.md
7408fb2 
Co-Authored-By: Soner Kalayci <sonerkalayci89@gmail.com>
@Geartrixy Geartrixy merged commit 6383785 into master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soner89 soner89 soner89 approved these changes

Assignees

@soner89 soner89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geartrixy @soner89