Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the LinkPreview API to get the page title #128

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

ZhymabekRoman
Copy link
Contributor

@ZhymabekRoman ZhymabekRoman commented Oct 15, 2024

Should fix #124, probably should fix #118, fixes major security problem - #81, closes #77, closes #46, closes #119, closes #116, should fix #114, should fix #93, should fix #41.

Doesn't affect #122

@DylanSpeiser
Copy link

Bumping this, looking forward to the YouTube title fix.

@wlo2
Copy link

wlo2 commented Nov 10, 2024

Looking forward for YouTube links fix too.

@yinsanwen
Copy link

Looking forward

Copy link
Owner

@zolrath zolrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, definitely an awesome service.
A couple of nitpicks so we don't hit their API unnecessarily but overall looks great!

main.ts Show resolved Hide resolved
settings.ts Outdated Show resolved Hide resolved
@ZhymabekRoman ZhymabekRoman requested a review from zolrath December 4, 2024 05:33
@ZhymabekRoman
Copy link
Contributor Author

@zolrath Done, waiting for review

@zolrath
Copy link
Owner

zolrath commented Dec 4, 2024

Works great, thanks for working on this! 🔥

@zolrath zolrath merged commit 9ac2d47 into zolrath:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment