Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overwriting top of file if hash not found #27

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

jamiekowalski
Copy link
Contributor

Simply bail out if placeholder has is not found in the current file. User may have removed the link after pasting, or switched to a different file.

Resolves #20

@Sanqui
Copy link

Sanqui commented Jan 15, 2022

@jamiekowalski If your fixes don't get merged and the plugin ends up being abandoned, would you consider merging your fixes into the master branch of your fork and as such making your fork installable via BRAT?

@jamiekowalski
Copy link
Contributor Author

@Sanqui good idea, done. See release 1.2.4 here: https://github.com/jamiekowalski/obsidian-auto-link-title

@Sanqui
Copy link

Sanqui commented Jan 16, 2022

Awesome, thank you. I love open source!

@Sanqui
Copy link

Sanqui commented Jan 16, 2022

BTW, if the plugin remains abandoned, I got told by Licat (one of the Obsidian devs) on the Obsidian Discord that you can submit a PR to the Obsidian releases repository to swap it over to you. I do think this issue (silent corruption of the beginning of notes) is big enough to warrant that.

@jamiekowalski
Copy link
Contributor Author

@Sanqui I've sent an email to @zolrath to check in on whether he wants to keep maintaining the plugin in the near term. I'll consider submitting the PR to obsidian-releases as you suggest if I don't hear back within a couple weeks.

@zolrath
Copy link
Owner

zolrath commented Jan 19, 2022

Sorry for missing all of this, my github notifications are plagued with unimportant notifications and I've been missing these while busy with work.

I'll review and merge the outstanding PRs and cut a new release!

@zolrath
Copy link
Owner

zolrath commented Jan 19, 2022

Implementation looks good, a nice edgecase fix, thanks!

@zolrath zolrath merged commit 13c9076 into zolrath:main Jan 19, 2022
@Sanqui
Copy link

Sanqui commented Jan 19, 2022

Awesome, thanks for getting back to this @zolrath! I'm was afraid I would have to abandon the plugin over this bug, great to see this resolved :)

@jamiekowalski jamiekowalski deleted the issue-20-top-of-page branch January 19, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Will replace text at tops of other pages with link title
3 participants