Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the user interface notification for bad server certification #615

Open
tiffrobo opened this issue May 21, 2018 · 10 comments
Open

Disable the user interface notification for bad server certification #615

tiffrobo opened this issue May 21, 2018 · 10 comments

Comments

@tiffrobo
Copy link

tiffrobo commented May 21, 2018

img_4969 2

@N-Pex
Device: iPhone8
OS: 11.3.1
App version: release build 130

@n8fr8
Copy link
Contributor

n8fr8 commented May 29, 2018

This is also happening to Rosa. Any progress?

@n8fr8
Copy link
Contributor

n8fr8 commented May 29, 2018

@abeluck any thoughts on the server side of this possibly?

@N-Pex
Copy link
Collaborator

N-Pex commented May 29, 2018

Yes, I am pretty sure I've fixed it (a new UUID was used every time, so instead of "reusing" the notification a new one was created). I just need to be sure that the fix is not affecting things to the other extreme, i.e. showing too few notifications because they are lumped together. Will try to do a new build soon, probably tomorrow.

@n8fr8
Copy link
Contributor

n8fr8 commented May 29, 2018

Can you tell me more about when it is triggered? Is it generated by a connection to the push.zom.im server or the home.zom.im?

Let's talk on the scrum today.

@n8fr8
Copy link
Contributor

n8fr8 commented May 29, 2018

(oops tomorrow!)

@N-Pex
Copy link
Collaborator

N-Pex commented May 29, 2018

@n8fr8 I haven't actually tried to chase the cause, I've only fixed the symptom (by faking a connection problem in the code, so that it tries to show a new notification when trying to reconnect). I've not seen this, but that's probably because I don't test on the home.zom.im server. I can give that a go tomorrow as well.

@tiffrobo
Copy link
Author

Let's keep an eye out for this. @N-Pex Fixed the multiple push notifications and user should only see one, but we need to figure out if this is a false push notification and if so, triggered by what.

@n8fr8
Copy link
Contributor

n8fr8 commented Jun 20, 2018

Can we just disable this notification? Too many false positives.

@N-Pex
Copy link
Collaborator

N-Pex commented Jun 25, 2018

Please retest in build 134.

N-Pex added a commit that referenced this issue Jun 28, 2018
Disabled for now, fix for issue #615.
@tiffrobo
Copy link
Author

So! Kaci was seeing this error, but I she has the app store version. I haven't seen it during testing build 134 or 135.

Device: iPhone 6, iPhone 7
OS: 10.3.3, 11.2.2
App version: build 135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants