Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable encryption automatically for new users and new group chats created #625

Open
tiffrobo opened this issue Jun 27, 2018 · 3 comments
Open
Assignees

Comments

@tiffrobo
Copy link

When you start a new group or are a new user auto enable encryption.

  • Leave the visibility of settings UI toggle to be enabled by the user
@tiffrobo tiffrobo added this to the Final Spring Sprint milestone Jun 27, 2018
N-Pex added a commit that referenced this issue Jun 28, 2018
For issue #625. Now we'll use the same logic as upstream, i.e. if we have a device for ANY of the members in the group, default to "OMEMO".
@N-Pex
Copy link
Collaborator

N-Pex commented Jun 28, 2018

Ok, so turns out we had previously overridden upstream to start groups in "plaintext". Now, I removed that code to have the same logic as upstream, which is "if we have keys for any of the room occupants, we can do omemo", see bestTransportSecurity in OTRMPPRoom.swift.

@n8fr8 Good enough?

@n8fr8
Copy link
Contributor

n8fr8 commented Jun 28, 2018

Yes, great!

@tiffrobo
Copy link
Author

tiffrobo commented Jun 29, 2018

@N-Pex So what should I see as a user in the UI? Will I see the Group Encryption option with the toggle to 'on' in every new group as a new user? Or is it 'enabled' but in order to see the UI I must go into my settings and turn the master toggle on?

Right now I don't see any UI in group chat until I go into my settings and enable it from there. However, once I do, in my groups I then see the toggle and it's already 'on'

Device: iPhone 6, iPhone 7, iPad
OS: 10.3.3, 11.2.2, 10.3.2
App version: build 135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants