This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Use raw XHR rather than $http to access progress events on upload #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,15 +53,34 @@ filedrop.Files.prototype.list = function() { | |||
|
|
|||
|
|
|||
| /** | |||
| * Upload a file. | |||
| * Upload a file. Uses raw xhr rather than $http to access progress events. | |||
There was a problem hiding this comment.
nit: instead of describing implementation, let's describe that the returned promise sends progress updates (and what the type of those updates is).
|
LGTM 👍 Just a couple of nits. Thank you for working on this! |
akosel
force-pushed
the
upload-xhr-promise
branch
from
68b5246 to
dc3d41a
Compare
zombiezen
added a commit
that referenced
this pull request
Dec 2, 2015
Upload using raw XHR rather than $http to access progress events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step we talked about. It's now possible to access progress events during the upload.
The next step is to create the UploadManager service to centrally handle all uploads currently in flight.