Skip to content

Commit

Permalink
get tests working again maybe
Browse files Browse the repository at this point in the history
  • Loading branch information
pcai committed Sep 29, 2024
1 parent b848978 commit 91246b1
Show file tree
Hide file tree
Showing 9 changed files with 97 additions and 49 deletions.
22 changes: 22 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/ruby
{
"name": "Ruby",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/ruby:1-3.3-bullseye"

// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "ruby --version",

// Configure tool-specific properties.
// "customizations": {},

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
81 changes: 45 additions & 36 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,42 +10,51 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby:
- '2.5.8'
- '2.7.2'
- '3.0.0'
- '3.1.2'
- 'head'
gemfile:
- gemfiles/rails_5_1.gemfile
- gemfiles/rails_5_2.gemfile
- gemfiles/rails_6_0.gemfile
- gemfiles/rails_6_1.gemfile
- gemfiles/rails_7_0.gemfile
- gemfiles/rails_head.gemfile
exclude:
- ruby: "2.5.8"
gemfile: gemfiles/rails_7_0.gemfile
- ruby: "2.5.8"
gemfile: gemfiles/rails_head.gemfile
- ruby: "2.7.2"
gemfile: gemfiles/rails_head.gemfile
- ruby: "3.0.0"
gemfile: gemfiles/rails_5_1.gemfile
- ruby: "3.0.0"
gemfile: gemfiles/rails_5_2.gemfile
- ruby: "3.1.2"
gemfile: gemfiles/rails_5_1.gemfile
- ruby: "3.1.2"
gemfile: gemfiles/rails_5_2.gemfile
- ruby: "3.1.2"
gemfile: gemfiles/rails_6_0.gemfile
- ruby: "head"
gemfile: gemfiles/rails_5_1.gemfile
- ruby: "head"
gemfile: gemfiles/rails_5_2.gemfile
- ruby: "head"
gemfile: gemfiles/rails_6_0.gemfile
include:
- ruby: "2.5"
gemfile: gemfiles/rails_5_1.gemfile
- ruby: "2.5"
gemfile: gemfiles/rails_5_2.gemfile
- ruby: "2.5"
gemfile: gemfiles/rails_6_0.gemfile
- ruby: "2.5"
gemfile: gemfiles/rails_6_1.gemfile
- ruby: "2.7"
gemfile: gemfiles/rails_5_1.gemfile
- ruby: "2.7"
gemfile: gemfiles/rails_5_2.gemfile
- ruby: "2.7"
gemfile: gemfiles/rails_6_0.gemfile
- ruby: "2.7"
gemfile: gemfiles/rails_6_1.gemfile
- ruby: "2.7"
gemfile: gemfiles/rails_7_0.gemfile
- ruby: "3.0"
gemfile: gemfiles/rails_6_0.gemfile
- ruby: "3.0"
gemfile: gemfiles/rails_6_1.gemfile
- ruby: "3.0"
gemfile: gemfiles/rails_7_0.gemfile
- ruby: "3.1"
gemfile: gemfiles/rails_6_0.gemfile
- ruby: "3.1"
gemfile: gemfiles/rails_6_1.gemfile
- ruby: "3.1"
gemfile: gemfiles/rails_7_0.gemfile
- ruby: "3.2"
gemfile: gemfiles/rails_6_0.gemfile
- ruby: "3.2"
gemfile: gemfiles/rails_6_1.gemfile
- ruby: "3.2"
gemfile: gemfiles/rails_7_0.gemfile
- ruby: "3.3"
gemfile: gemfiles/rails_6_0.gemfile
- ruby: "3.3"
gemfile: gemfiles/rails_6_1.gemfile
- ruby: "3.3"
gemfile: gemfiles/rails_7_0.gemfile
- ruby: "head"
gemfile: gemfiles/rails_head.gemfile
env:
BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ source 'https://rubygems.org'
gemspec

group :development, :test do
gem "sqlite3", :platform => [:ruby, :mswin, :mingw]
gem "sqlite3", '~> 1.4', :platform => [:ruby, :mswin, :mingw]
gem "activerecord-jdbcsqlite3-adapter", '~> 1.3.13', :platform => :jruby
gem "test-unit", "~> 3.0"
end
15 changes: 13 additions & 2 deletions derailed_benchmarks.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,26 @@ Gem::Specification.new do |gem|
gem.add_dependency "rack", ">= 1"
gem.add_dependency "rake", "> 10", "< 14"
gem.add_dependency "thor", ">= 0.19", "< 2"
gem.add_dependency "ruby-statistics", ">= 2.1"
if RUBY_VERSION >= '3.0'
gem.add_dependency "ruby-statistics", ">= 4.0"
else
gem.add_dependency "ruby-statistics", ">= 2.1"
end
gem.add_dependency "mini_histogram", ">= 0.3.0"
gem.add_dependency "dead_end", ">= 0"
gem.add_dependency "rack-test", ">= 0"
gem.add_dependency "base64", ">= 0"
gem.add_dependency "mutex_m", ">= 0"
gem.add_dependency "bigdecimal", ">= 0"
gem.add_dependency "drb", ">= 0"
gem.add_dependency "logger", ">= 0"
gem.add_dependency "ostruct", ">= 0"
gem.add_dependency "ruby2_keywords", ">= 0"

gem.add_development_dependency "appraisal"
gem.add_development_dependency "webrick", ">= 0"
gem.add_development_dependency "capybara", "~> 2"
gem.add_development_dependency "m"
gem.add_development_dependency "rails", "> 3", "<= 7"
gem.add_development_dependency "rails", "> 3", "< 7.1"
gem.add_development_dependency "devise", "> 3", "< 6"
end
3 changes: 2 additions & 1 deletion gemfiles/rails_6_0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ source "https://rubygems.org"
gem "rails", "~> 6.0.0"

group :development, :test do
gem "sqlite3", platform: [:ruby, :mswin, :mingw]
gem "sqlite3", '~> 1.4', platform: [:ruby, :mswin, :mingw]
gem "activerecord-jdbcsqlite3-adapter", "~> 1.3.13", platform: :jruby
gem "test-unit", "~> 3.0"
gem "psych", "~> 3.0"
end

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/rails_6_1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ gem "net-imap", require: false
gem "net-pop", require: false

group :development, :test do
gem "sqlite3", platform: [:ruby, :mswin, :mingw]
gem "sqlite3", '~> 1.4', platform: [:ruby, :mswin, :mingw]
gem "activerecord-jdbcsqlite3-adapter", "~> 1.3.13", platform: :jruby
gem "test-unit", "~> 3.0"
end
Expand Down
4 changes: 2 additions & 2 deletions gemfiles/rails_7_0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

source "https://rubygems.org"

gem "rails", "~> 7.0"
gem "rails", "~> 7.0.0"

group :development, :test do
gem "sqlite3", platform: [:ruby, :mswin, :mingw]
gem "sqlite3", '~> 1.4', platform: [:ruby, :mswin, :mingw]
gem "activerecord-jdbcsqlite3-adapter", "~> 1.3.13", platform: :jruby
gem "test-unit", "~> 3.0"
end
Expand Down
7 changes: 6 additions & 1 deletion lib/derailed_benchmarks/stats_from_dir.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
# frozen_string_literal: true

require 'bigdecimal'
require 'statistics'
# keep this in sync with gemspec
if RUBY_VERSION >= '3.0'
require 'ruby-statistics'
else
require 'statistics'
end
require 'stringio'
require 'mini_histogram'
require 'mini_histogram/plot'
Expand Down
10 changes: 5 additions & 5 deletions test/integration/tasks_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -120,18 +120,18 @@ def rake(cmd, options = {})
env = {
"PATH_TO_HIT" => 'foo_secret',
"TEST_COUNT" => "2",
"HTTP_AUTHORIZATION" => "Basic #{Base64.encode64("admin:secret")}",
"HTTP_AUTHORIZATION" => "Basic #{Base64.strict_encode64("admin:secret")}",
"HTTP_CACHE_CONTROL" => "no-cache"
}
result = rake "perf:test", env: env
assert_match 'Endpoint: "foo_secret"', result
assert_match /"Authorization"=>"Basic YWRtaW46c2VjcmV0\\n"/ , result
assert_match /"Cache-Control"=>"no-cache"/ , result
assert_match (/"Authorization"=>"Basic YWRtaW46c2VjcmV0"/), result
assert_match (/"Cache-Control"=>"no-cache"/), result

env["USE_SERVER"] = "webrick"
result = rake "perf:test", env: env
assert_match /"Authorization"=>"Basic YWRtaW46c2VjcmV0\\n"/ , result
assert_match /"Cache-Control"=>"no-cache"/ , result
assert_match (/"Authorization"=>"Basic YWRtaW46c2VjcmV0"/), result
assert_match (/"Cache-Control"=>"no-cache"/), result
end

test 'USE_SERVER' do
Expand Down

0 comments on commit 91246b1

Please sign in to comment.