-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an option to convert a method with IAsyncEnumerable to IList, ReadOnlySpan, Span #23
Draft
ValerieFernandes
wants to merge
26
commits into
zompinc:master
Choose a base branch
from
ValerieFernandes:fix-embedded-resource
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
141c9ea
Create enum for valid collection types
ValerieFernandes 1c44e77
Add a property for variations
ValerieFernandes 8d360da
Assign values so property can use or flags
ValerieFernandes de71e8e
Add comments to pass style checking and include System
ValerieFernandes 3171bb0
Provide async rewriter with dictionary of overrides to the typical re…
ValerieFernandes 76a3101
Add variation namespaces and retireve value from attributedata
ValerieFernandes ead92c4
Add enum to library so it can be used in generator
ValerieFernandes 4bd3631
Check property to find which variants have been chosen
ValerieFernandes 250d380
Update to use differet types and IEnumerable when nothing has been se…
ValerieFernandes 7da552e
Add tests for all variations of CollectionTypes
ValerieFernandes ad229e3
Move IEnumerable to front of enum and use its CollectionTypes values …
ValerieFernandes aee4d45
Add using system directive back in
ValerieFernandes 646522b
Fix test failures, and alter test to use CollectionTypes.
ValerieFernandes da595e6
Remove private property
ValerieFernandes c8744a0
Match by parameter name instead of list index
ValerieFernandes f6cff45
Add attribute for options
ValerieFernandes 1916f7c
Seperate the ReplaceWith Attribute
ValerieFernandes c12fb15
Remove attribute from generated function
ValerieFernandes 09bd558
Add new paramter types to dictionary from replace attribute
ValerieFernandes d63db80
Remove attribute from duplicating
ValerieFernandes 06d4e75
Stop tests from comparing with new generated attribute
ValerieFernandes 9d5b638
Retireve attribute and find its variation
ValerieFernandes c4aa8b6
Add CollectionTypes enum as embedded resource (not working as of now)
ValerieFernandes 1d94cb8
Fix references in test projects
ValerieFernandes 8a6b1c9
Fix logical path
ValerieFernandes f3e9358
Generate enum from file instead of string
ValerieFernandes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
namespace Zomp.SyncMethodGenerator | ||
{ | ||
/// <summary> | ||
/// All types that an IAsyncEnumerable can be converted into. | ||
/// </summary> | ||
[Flags] | ||
public enum CollectionTypes | ||
{ | ||
/// <summary> | ||
/// Type for System.Collections.Generic.IEnumerable . | ||
/// </summary> | ||
IEnumerable = 1, | ||
|
||
/// <summary> | ||
/// Type for System.Collections.Generic.IList . | ||
/// </summary> | ||
IList = 2, | ||
|
||
/// <summary> | ||
/// Type for System.ReadOnlySpan . | ||
/// </summary> | ||
ReadOnlySpan = 4, | ||
|
||
/// <summary> | ||
/// Type for System.Span . | ||
/// </summary> | ||
Span = 8, | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you're busy with school and there's 0 urgency on this one. Just making a comment to not forget.
[0]
is going to grab a wrong attribute if you have something like[Obsolete]
in the first position.