Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is not implemented on v7.0.0 scenarigo binary in releases page #132

Closed
konifar opened this issue Sep 6, 2021 · 2 comments · Fixed by #133
Closed

Plugin is not implemented on v7.0.0 scenarigo binary in releases page #132

konifar opened this issue Sep 6, 2021 · 2 comments · Fixed by #133

Comments

@konifar
Copy link

konifar commented Sep 6, 2021

Overview

Thanks for awesome tool! 😃
I tried using scenarigo but plugin seems not working well.

Details

I created a minimum example to reproduce this.
https://github.com/konifar/scenarigo-plugin-example

The error message is below.

$ ./v0.7.0_Darwin_x86_64/scenarigo run
$ --- FAIL: github.yml (0.00s)
$     --- FAIL: github.yml/get_scenarigo_repository (0.00s)
$             failed to open plugin: plugin: not implemented

Plugin has been introduced since Go 1.8 and scenarigo supports Go 1.16 or later, so it should be no problem.

References

Go binary needs cgo to use plugin?
golang/go#19569 plugin: requires CGO_ENABLED=1

I tried removing CGO_ENABLED=0 from .goreleaser.yml#11 and used a binary which build on local, it worked well. (I'm not sure it should be removed actually...)

Probably this issue is also related.
kubernetes-sigs/kustomize#2299

Environments

@zoncoen
Copy link
Owner

zoncoen commented Sep 6, 2021

Thanks for your report! This is my mistake, I'll fix it 🙇

@konifar
Copy link
Author

konifar commented Sep 7, 2021

Thanks for quick fix! I'll use new version 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants