style(common): fix batch 7/26 of linter warnings

Changes made:
- Fixed lint warnings associated with any-type for truthyness and nonBlankString checking
- Fixed lint warnings associated with type-aliases in logger
- Fixed lint warnings associated with  non-any type in getAllMethodNames and getAllFieldNames
- Fixed lint errors associated with unexpected any for private-public keypairs
- Added an isRecord user-defined type guard in the common package that
can narrow `unknown` types into `Record<string, unknown>`

Fixes hyperledger-cacti#1356

Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Signed-off-by: akankshadixit <akanksha.dixit12@gmail.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>

packages/cactus-common/src/main/typescript/checks.ts

@@ -9,7 +9,7 @@ export class Checks {
    * @param code The code of the error if `checkResult is falsy.
    */
   public static truthy(
-    checkResult: any,
+    checkResult: unknown,
     subjectOfCheck = "variable",
     code = "-1",
   ): void {
@@ -28,7 +28,7 @@ export class Checks {
    * @param code The code of the error if `checkResult is falsy.
    */
   public static nonBlankString(
-    value: any,
+    value: unknown,
     subject = "variable",
     code = "-1",
   ): void {

packages/cactus-common/src/main/typescript/logging/logger-provider.ts

@@ -26,7 +26,7 @@ export class LoggerProvider {
     LoggerProvider.logLevel = logLevel;
     if (applyToCachedLoggers) {
       LoggerProvider.loggers.forEach((logger: Logger) =>
-        logger.setLogLevel(logLevel as any),
+        logger.setLogLevel(logLevel as LogLevelDesc),
       );
     }
   }

packages/cactus-common/src/main/typescript/objects.ts

@@ -29,31 +29,32 @@ export class Objects {
    *
    * @param anObject
    */
-  public static getAllMethodNames(anObject: any): string[] {
+  public static getAllMethodNames(anObject: unknown): string[] {
+    let aRecord = anObject as Readonly<Record<string, unknown>>;
     let properties: string[] = [];
     do {
-      const symbols = Object.getOwnPropertySymbols(anObject);
+      const symbols = Object.getOwnPropertySymbols(aRecord);
       const symbolPropertyNames = symbols.map((aSymbol) => aSymbol.toString());
 
-      const propertyNamesCurrent = Object.getOwnPropertyNames(anObject)
+      const propertyNamesCurrent = Object.getOwnPropertyNames(aRecord)
         .concat(symbolPropertyNames)
         .sort()
         .filter((propertyName: string, index: number, arr) => {
           return (
-            typeof anObject[propertyName] === "function" &&
+            typeof aRecord[propertyName] === "function" &&
             propertyName !== "constructor" &&
             (index === 0 || propertyName !== arr[index - 1]) &&
             properties.indexOf(propertyName) === -1
           );
         });
 
       properties = properties.concat(propertyNamesCurrent);
-      anObject = Object.getPrototypeOf(anObject);
-    } while (anObject && Object.getPrototypeOf(anObject));
+      aRecord = Object.getPrototypeOf(aRecord);
+    } while (aRecord && Object.getPrototypeOf(aRecord));
     return properties;
   }
 
-  public static getAllFieldNames(anObject: any): string[] {
+  public static getAllFieldNames(anObject: Record<string, unknown>): string[] {
     const allFieldNames = [];
     for (const propertyKey in anObject) {
       if (Object.prototype.hasOwnProperty.call(anObject, propertyKey)) {

packages/cactus-common/src/main/typescript/public-api.ts

@@ -25,3 +25,5 @@ export {
   IJoseFittingJwtParams,
   isIJoseFittingJwtParams,
 } from "./authzn/i-jose-fitting-jwt-params";
+
+export { isRecord } from "./types/is-record";

packages/cactus-common/src/main/typescript/secp256k1-keys.ts

@@ -2,8 +2,8 @@ import crypto from "crypto";
 import secp256k1 from "secp256k1";
 
 export interface ISignerKeyPair {
-  privateKey: any;
-  publicKey: any;
+  privateKey: Buffer;
+  publicKey: Uint8Array;
 }
 
 export class Secp256k1Keys {
@@ -12,7 +12,7 @@ export class Secp256k1Keys {
    * @return Generated key pair
    */
   static generateKeyPairsBuffer(): ISignerKeyPair {
-    let privKey: any;
+    let privKey: Buffer;
     // generate secp256K1 private key
     do {
       privKey = crypto.randomBytes(32);

packages/cactus-common/src/main/typescript/types/is-record.ts

@@ -0,0 +1,3 @@
+export function isRecord(x: unknown): x is Record<string, unknown> {
+  return !!x && typeof x === "object" && x !== null;
+}