Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip netcoreapp3.1 and add coverage #24

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

viceice
Copy link
Collaborator

@viceice viceice commented Jan 5, 2023

  • remove netcoreapp3.1 tests (EOL)
  • generate code coverage
  • update required deps

@viceice viceice requested a review from zone117x January 5, 2023 12:22
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@c5d52d9). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 4ca6898 differs from pull request most recent head 067b431. Consider uploading reports for the commit 067b431 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage          ?   69.68%           
=========================================
  Files             ?        2           
  Lines             ?     3088           
  Branches          ?        0           
=========================================
  Hits              ?     2152           
  Misses            ?      936           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

We probably need a unit test that iterates through all available types and calls the lookup functions in order to have decent coverage percentage.

@viceice
Copy link
Collaborator Author

viceice commented Jan 5, 2023

Looks great, thank you!

We probably need a unit test that iterates through all available types and calls the lookup functions in order to have decent coverage percentage.

sounds good, will do so in separate PR

@viceice viceice merged commit 12923f3 into master Jan 5, 2023
@viceice viceice deleted the chore/skip-netcoreapp3.1-tests branch January 5, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants