Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BASIC01 does not find parent domain when testing an .arpa-domain #1280

Closed
repperille opened this issue Aug 23, 2023 · 3 comments · Fixed by #1282
Closed

BASIC01 does not find parent domain when testing an .arpa-domain #1280

repperille opened this issue Aug 23, 2023 · 3 comments · Fixed by #1282
Assignees
Labels
A-TestCase Area: Test case specification or implementation of test case T-Bug Type: Bug in software or error in test case description
Milestone

Comments

@repperille
Copy link
Collaborator

When starting a normal test with the .arpa-domain
0.0.9.0.0.0.7.0.1.0.0.2.ip6.arpa
the test fails in BASIC01 with B01_NO_CHILD even though it is a sone
(https://zonemaster.se/en/result/d308120abac1f3de)

$ dig soa 0.0.9.0.0.0.7.0.1.0.0.2.ip6.arpa
...
;; ANSWER SECTION:
0.0.9.0.0.0.7.0.1.0.0.2.ip6.arpa. 206 IN SOA ns.nta.no. root.nta.no. 2023081801 28800 7200 1209600 86400

The same error (B01_NO_CHILD) happens when testing the parent zone
0.0.7.0.1.0.0.2.ip6.arpa
(https://zonemaster.se/en/result/0e98155738848971)

$ dig soa 0.0.7.0.1.0.0.2.ip6.arpa
...
;; ANSWER SECTION:
0.0.7.0.1.0.0.2.ip6.arpa. 2001 IN SOA ns.uninett.no. hostmaster.uninett.no. 2023082303 36000 3600 1814400 900

But it works when testing the parent of the parent!
7.0.1.0.0.2.ip6.arpa
(https://zonemaster.se/en/result/42f9f0f035fa5f16)

$ dig soa 7.0.1.0.0.2.ip6.arpa
...
;; ANSWER SECTION:
7.0.1.0.0.2.ip6.arpa. 1044 IN SOA pri.authdns.ripe.net. dns.ripe.net. 1692256305 3600 600 864000 3600

@matsduf matsduf added the T-Bug Type: Bug in software or error in test case description label Aug 24, 2023
@matsduf
Copy link
Contributor

matsduf commented Aug 24, 2023

Something is in error when Zonemaster cannot find the parent zone in this case:

$ zonemaster-cli 0.0.9.0.0.0.7.0.1.0.0.2.ip6.arpa
Seconds Level    Testcase       Message
======= ======== ============== =======
   0.00 INFO     UNSPECIFIED    Using version v4.7.2 of the Zonemaster engine.
   4.79 WARNING  BASIC01        The parent zone cannot be determined on name servers "".
   4.80 ERROR    BASIC01        "0.0.9.0.0.0.7.0.1.0.0.2.ip6.arpa" does not exist as a DNS zone. Try to test "0.9.0.0.0.7.0.1.0.0.2.ip6.arpa" instead.
   8.49 CRITICAL UNSPECIFIED    Not enough data about 0.0.9.0.0.0.7.0.1.0.0.2.ip6.arpa was found to be able to run tests.

$ zonemaster-cli 0.0.9.0.0.0.7.0.1.0.0.2.ip6.arpa --raw
   0.00 INFO     UNSPECIFIED    GLOBAL_VERSION   version=v4.7.2
   4.69 WARNING  BASIC01        B01_PARENT_UNDETERMINED   ns_ip_list=
   4.69 ERROR    BASIC01        B01_NO_CHILD   domain_child=0.0.9.0.0.0.7.0.1.0.0.2.ip6.arpa; domain_super="0.9.0.0.0.7.0.1.0.0.2.ip6.arpa"
   8.10 CRITICAL UNSPECIFIED    CANNOT_CONTINUE   domain=0.0.9.0.0.0.7.0.1.0.0.2.ip6.arpa

@matsduf matsduf added this to the v2023.2 milestone Aug 24, 2023
@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Aug 24, 2023
@tgreenx
Copy link
Contributor

tgreenx commented Aug 29, 2023

Hi @repperille,

Thanks for the feedback!

I can confirm that this is a bug in the implementation. It has been identified and we will provide a fix.

@tgreenx tgreenx self-assigned this Aug 29, 2023
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Aug 29, 2023
Corrects variables
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Aug 29, 2023
Makes use of the correct variables (fixes zonemaster#1280)
@tgreenx tgreenx mentioned this issue Aug 29, 2023
@marc-vanderwal marc-vanderwal linked a pull request Aug 30, 2023 that will close this issue
@tgreenx tgreenx modified the milestones: v2023.2, v2023.1.4 Aug 30, 2023
@tgreenx
Copy link
Contributor

tgreenx commented Sep 7, 2023

Solved by #1282.

A fix release (v2023.1.4) containing this PR is scheduled for tomorrow. Thanks again for the report.

@tgreenx tgreenx closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case T-Bug Type: Bug in software or error in test case description
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants