Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests are leaking queries when network should be off. #1400

Closed
matsduf opened this issue Dec 2, 2024 · 1 comment · Fixed by #1402
Closed

Unit tests are leaking queries when network should be off. #1400

matsduf opened this issue Dec 2, 2024 · 1 comment · Fixed by #1402
Labels
T-Bug Type: Bug in software or error in test case description
Milestone
v2024.2

Comments

@matsduf
Copy link
Contributor

matsduf commented Dec 2, 2024 •
edited
Loading

When network is off the unit tests should not send any queries to the network.

At least t/Test.t sends queries to the network when network is off.
@matsduf matsduf added the T-Bug Type: Bug in software or error in test case description label Dec 2, 2024
@matsduf matsduf added this to the v2024.2 milestone Dec 2, 2024
@matsduf matsduf mentioned this issue Dec 4, 2024
Merged
@tgreenx tgreenx linked a pull request Dec 4, 2024 that will close this issue
Fixes unit tests so that they do not leak queries #1402
Merged
@tgreenx
Copy link
Contributor

tgreenx commented Dec 9, 2024

Solved by #1402 (release v2024.2)

@tgreenx tgreenx closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Bug Type: Bug in software or error in test case description
Projects
None yet
Milestone
v2024.2
Development

Successfully merging a pull request may close this issue.

Fixes unit tests so that they do not leak queries matsduf/zonemaster-engine
2 participants
@matsduf @tgreenx