Fixes unit tests so that they do not leak queries #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
added
T-Bug
matsduf
requested review from
mattias-p,
tolvmannen,
tgreenx,
marc-vanderwal and
MichaelTimbert
tgreenx
reviewed
Dec 4, 2024
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
approved these changes
Dec 4, 2024
|
An alternative approach would be to make the scrambling deterministic in Test.t by calling |
The scrambling is done in the test case code using function/method |
mattias-p
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Unit tests in
t/Test.tis leaking queries as reported in #1400. It turned out that network was not correctly set off. When that has been done there are two test cases, Nameserver08 and Nameserver09, that cannot be tested with recorded data.This PR fixes the leaking unit test, but as a consequence Nameserver08 and Nameserver09 are excluded when testing with recorded data. This has also been documented in issue #1403.
The data file is also updated.
Context
#1400
How to test this PR