Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to unit test Nameserver08 and Nameserver09 #1403

Open
matsduf opened this issue Dec 4, 2024 · 2 comments · Fixed by #1402
Open

Find a way to unit test Nameserver08 and Nameserver09 #1403

matsduf opened this issue Dec 4, 2024 · 2 comments · Fixed by #1402
Milestone

Comments

@matsduf
Copy link
Contributor

matsduf commented Dec 4, 2024

#1402 fixes so that the unit tests in t/Test.t do not leak queries when using recorded data (normal case). One consequence is that Nameserver08 and Nameserver08 cannot normally be tested since they cannot be tested with recorded data. The queries from the test cases are are randomly varied, and that does not work with recorded data.

One option is to change the test cases so that they always send fixed queries, maybe to the price that they send multiple, but fixed queries.

Another option is to let CI do the testing. A small name server could probably be started there. The test would then be a live test, but only locally. Such testing could then only be executed in a special setting, on CI and on a test zone server.

@tgreenx
Copy link
Contributor

tgreenx commented Dec 5, 2024

Partly fixed by #1402, which fixes the leaking but also disable the testing of those test cases for pre-recorded data. A more complete solution would need to use a fixed seed, see #1402 (comment).

@tgreenx tgreenx linked a pull request Dec 5, 2024 that will close this issue
@tgreenx
Copy link
Contributor

tgreenx commented Dec 9, 2024

Also see zonemaster/zonemaster#1009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants