Fix undef eq comparison #1363
Merged
Fix undef eq comparison #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgreenx
added
the
V-Patch
tgreenx
requested review from
mattias-p,
matsduf,
marc-vanderwal and
MichaelTimbert
marc-vanderwal
previously approved these changes
Jun 17, 2024
|
I disagree with the premise of this PR. For the effective profile, all properties are always set, i.e. they have defined values. If $src_address is ever undef here then we have a bug in the profile module and we should fix it there instead. |
mattias-p
approved these changes
Jun 17, 2024
marc-vanderwal
approved these changes
Jun 17, 2024
Release testing for v2024.1I've verified that the default profile contains the default values for "resolver.source4" and "resolver.source6". |
mattias-p
added
the
S-ReleaseTested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes an oversight from #1343.
Changes
How to test this PR
Checks should now pass.