Add peek/peek_finalize to VariablePacket #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VariablePacket::peek was refactored from parse to read the protocol header and additionally return the header bytes ( ignored in parse but used in peek_finalize ).
VariablePacket::peek_finialize reads the rest of the packet returning a decoded packet and the entire buffer.
VariablePacket::parse uses peek to read the header, no braking changes for anything existing.
The use case for this is that as a broker/bridge you want to be able to early reject connections by peeking into the fixed header if the control type is relevant to the current situation, logging/aborting/exiting without processing the remaining data. To avoid unnecessary encoding/decoding or rereading the buffer in order to forward the packet, the entire packet buffer is returned in peek_finalize.
Added basic tests for VariablePacket::parse and VariablePacket::peek(_finalize)
This affects only tokio async use.