Make PacketType the size of u8 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
pktyp-byte
branch
from
0634273
to
392f51d
Compare
zonyitoo
reviewed
Mar 27, 2021
src/control/packet_type.rs
Outdated
| /// ControlType as defined by the [MQTT spec]. | ||
| /// | ||
| /// [MQTT spec]: http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Table_2.2_- | ||
| pub fn new(t: ControlType, flags: u8) -> Option<PacketType> { |
There was a problem hiding this comment.
It shouldn't be Option. You may want to use Result instead.
|
@coolreader18 What do you think? It has been a while since last release. I should publish a new version. |
|
Well I originally had it returning |
|
Although it only is an unit error type, but it should be an A wrapper is better for implementing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that methods on ConnectPacket weren't properly setting flags values (
set_dup(false)wouldn't clear the bit), and I also realized it should be possible to pack it into one byte instead of 2.