Fix reported line/column numbers in error message #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The numbers (in common sense) start counting from 1, not 0. This can be seen in a few editors, such as: Sublime Text, VS Code, Notepad++.
Chocobo1
force-pushed
the
line
branch
3 times, most recently
from
26ba5f1
to
597ae6e
Compare
matthiasbeyer
added a commit
to rust-cli/config-rs
that referenced
this pull request
Jul 20, 2023
In
zonyitoo/rust-ini#95
the reported line and column was fixed in rust-ini. This patch adapts
for this change.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numbers (in common sense) start counting from 1, not 0.
This can be seen in a few editors, such as: Sublime Text, VS Code, Notepad++.