Merge pull request #27 from zoobestik/multi-tests

Run tests for diffirent webpack configs

.babelrc

@@ -1,11 +1,12 @@
 {
     "presets": [
         [ "@babel/preset-env", {
+            "corejs": 3,
             "targets": {
-                "node": "8"
+                "node": "8.0.0"
             },
             "loose": true,
-            "useBuiltIns": "entry"
+            "useBuiltIns": "usage"
         } ]
     ]
 }

.gitignore

@@ -13,4 +13,4 @@ yarn.lock
 
 .eslintcache
 lib/**.js
-test/_out
+test/**/_out

.travis.yml

@@ -13,6 +13,7 @@ node_js:
   - "13"
   - "node"
 
+before_script: npm run test-prepare
 script: npm test
 
 branches:

package.json

@@ -30,7 +30,8 @@
   },
   "scripts": {
     "lint": "eslint --cache .",
-    "test": "npm run build && mocha",
+    "test": "npm run build && mocha \"./test/*/*.spec.js\"",
+    "test-prepare": "cd test/webpack2 && npm install && cd ../webpack4 && npm install && cd ../webpack5 && npm install",
     "build": "babel src --out-dir lib",
     "prepublish": "npm run build"
   },
@@ -55,14 +56,12 @@
     "@babel/core": "^7.7.5",
     "@babel/preset-env": "^7.7.6",
     "babel-eslint": "^10.0.0",
-    "css-loader": "^0.28.5",
+    "core-js": "^3.10.0",
     "eslint": "^6.7.2",
     "eslint-config-airbnb-base": "^14.0.0",
     "eslint-plugin-import": "^2.7.0",
-    "extract-text-webpack-plugin": "^2.1.0",
     "mocha": "^6.2.2",
     "pre-commit": "^1.2.2",
-    "rimraf": "^3.0.0",
-    "webpack": "^2.3.3"
+    "rimraf": "^3.0.0"
   }
 }

test/integrations.js → test/lib/integrations.js

@@ -2,19 +2,36 @@ const fs = require('fs');
 const join = require('path').join;
 const rimraf = require('rimraf');
 const assert = require('assert');
-const webpack = require('webpack');
-const getWebpackConfig = require('./webpack.config.js');
 
 const root = join(__dirname, 'integrations');
-const output = join(__dirname, '_out');
 
-describe('Integrations with webpack 2', function() {
+function runIntegrations(basePath, version) {
     this.timeout(5000);
 
-    const cases = fs.readdirSync(root);
+    const output = join(basePath, '_out');
 
     rimraf.sync(output);
 
+    const nodeVersions = process.version.split('.');
+    const nodeMajorVersion =  parseInt(nodeVersions[0].substring(1), 10);
+    const nodeMinorVersion =  parseInt(nodeVersions[1], 10);
+
+    const isEnvCorrect = !(
+        (version === '4' && nodeMajorVersion === 8 && nodeMinorVersion === 0) ||
+        (version === '5' && nodeMajorVersion < 10)
+    );
+
+    if (!isEnvCorrect) {
+        it('webpack ' + version + ' unsuppported with node ' + process.version, function() {
+           assert.ok(true);
+        });
+        return;
+    }
+
+    const cases = fs.readdirSync(root);
+    const webpack = require(join(basePath, 'node_modules', 'webpack'));
+    const getWebpackConfig = require(join(basePath, 'webpack.config.js'));
+
     cases.forEach(function(testCase) {
         it('with ' + testCase + ' test', function() {
             return new Promise(function(resolve, reject) {
@@ -23,6 +40,7 @@ describe('Integrations with webpack 2', function() {
                 const configFile = join(testDirectory, 'webpack.config.js');
 
                 var options = getWebpackConfig({
+                    basePath: basePath,
                     outputDirectory: outputDirectory,
                     testDirectory: testDirectory
                 });
@@ -39,7 +57,7 @@ describe('Integrations with webpack 2', function() {
                     if (err) return reject(err);
                     if (stats.hasErrors()) return reject(new Error(stats.toString()));
 
-                    const expectedCssExt = 'expected.css';
+                    const expectedCssExt = 'expected-v' + version + '.css';
 
                     fs.readdir(testDirectory, function(err, files) {
                         if (err) return reject(err);
@@ -59,7 +77,7 @@ describe('Integrations with webpack 2', function() {
                                 .replace(/\n$/g, '')
                                 .replace(/%%unit-hash%%/g, stats.hash);
 
-                            assert.equal(actual, expected,
+                            assert.strictEqual(actual, expected,
                                 'Output ' + testCase + ' — ' + name + ' file isn\'t equals ' + actualName
                             );
                         });
@@ -70,4 +88,6 @@ describe('Integrations with webpack 2', function() {
             });
         });
     });
-});
+}
+
+module.exports = runIntegrations;

test/lib/integrations/css-modules/expected-v5.css

@@ -0,0 +1 @@
+.c .d,.local-a.c .d,.local-c .local-d{color:#fff}

test/integrations/simple/webpack.config.js → test/lib/integrations/css-modules/webpack.config.js

@@ -1,4 +1,4 @@
-const CssoWebpackPlugin = require('../../../lib').default;
+const CssoWebpackPlugin = require('../../../../lib/index').default;
 
 module.exports = {
     plugins: [

test/lib/integrations/plugin-output-postfix/expected-v4.css

@@ -0,0 +1,4 @@
+.local-a.c .d { color: #fff; }
+.c .d { color: white; }
+.local-c .local-d { color: #ffffff; }
+

test/lib/integrations/plugin-output-postfix/expected-v5.css

@@ -0,0 +1,4 @@
+.local-a.c .d { color: #fff; }
+.c .d { color: white; }
+.local-c .local-d { color: #ffffff; }
+

test/lib/integrations/plugin-output-postfix/min.expected.css

@@ -0,0 +1 @@
+.c .d,.local-a.c .d,.local-c .local-d{color:#fff}

test/integrations/plugin-output-postfix/webpack.config.js → test/lib/integrations/plugin-output-postfix/webpack.config.js

@@ -1,4 +1,4 @@
-const CssoWebpackPlugin = require('../../../lib').default;
+const CssoWebpackPlugin = require('../../../../lib/index').default;
 
 module.exports = {
     plugins: [

test/lib/integrations/simple/expected-v5.css

@@ -0,0 +1 @@
+.local-a,.local-b,.local-c{color:#fff}

test/integrations/css-modules/webpack.config.js → test/lib/integrations/simple/webpack.config.js

@@ -1,4 +1,4 @@
-const CssoWebpackPlugin = require('../../../lib').default;
+const CssoWebpackPlugin = require('../../../../lib/index').default;
 
 module.exports = {
     plugins: [

test/lib/integrations/source-map-false/expected-v2.css

@@ -0,0 +1 @@
+.local-a,.local-b,.local-c{color:#fff}

test/lib/integrations/source-map-false/expected-v4.css

@@ -0,0 +1 @@
+.local-a,.local-b,.local-c{color:#fff}

test/lib/integrations/source-map-false/expected-v5.css

@@ -0,0 +1 @@
+.local-a,.local-b,.local-c{color:#fff}

test/integrations/source-map-false/webpack.config.js → test/lib/integrations/source-map-false/webpack.config.js

@@ -1,4 +1,4 @@
-const CssoWebpackPlugin = require('../../../lib').default;
+const CssoWebpackPlugin = require('../../../../lib/index').default;
 
 module.exports = {
     devtool: false,

test/integrations/source-map-filename/webpack.config.js → test/lib/integrations/source-map-filename/webpack.config.js

@@ -1,4 +1,4 @@
-const CssoWebpackPlugin = require('../../../lib').default;
+const CssoWebpackPlugin = require('../../../../lib/index').default;
 
 module.exports = {
     devtool: 'source-map',

test/lib/integrations/source-map-hidden/expected-v4.css

@@ -0,0 +1 @@
+.local-a.c .d{color:#fff}

test/lib/integrations/source-map-hidden/expected-v5.css

@@ -0,0 +1 @@
+.local-a.c .d{color:#fff}

test/integrations/source-map-hidden/webpack.config.js → test/lib/integrations/source-map-hidden/webpack.config.js

@@ -1,4 +1,4 @@
-const CssoWebpackPlugin = require('../../../lib').default;
+const CssoWebpackPlugin = require('../../../../lib/index').default;
 
 module.exports = {
     devtool: 'hidden-source-map',

test/integrations/source-map-inline/webpack.config.js → test/lib/integrations/source-map-inline/webpack.config.js

@@ -1,4 +1,4 @@
-const CssoWebpackPlugin = require('../../../lib').default;
+const CssoWebpackPlugin = require('../../../../lib/index').default;
 
 module.exports = {
     devtool: 'inline-source-map',

test/lib/integrations/source-map-with-import/a.css

@@ -0,0 +1,2 @@
+@import url('import.css');
+.a { color: white; }

test/integrations/source-map-with-import/webpack.config.js → test/lib/integrations/source-map-with-import/webpack.config.js

@@ -1,4 +1,4 @@
-const CssoWebpackPlugin = require('../../../lib').default;
+const CssoWebpackPlugin = require('../../../../lib/index').default;
 
 module.exports = {
     devtool: 'inline-source-map',

test/integrations/source-map/webpack.config.js → test/lib/integrations/source-map/webpack.config.js

@@ -1,4 +1,4 @@
-const CssoWebpackPlugin = require('../../../lib').default;
+const CssoWebpackPlugin = require('../../../../lib/index').default;
 
 module.exports = {
     devtool: 'source-map',

test/filter.js → test/unit/filter.spec.js

@@ -1,15 +1,15 @@
 const assert = require('assert');
-const CssoWebpackPlugin = require('../lib').default;
+const CssoWebpackPlugin = require('../../lib/index').default;
 
 describe('Constructor', function() {
     function testDefaultOptions(plugin) {
-        assert.deepEqual(plugin.options, {}, 'default options inited');
+        assert.deepStrictEqual(plugin.options, {}, 'default options inited');
     }
 
     function testDefaultFilter(plugin) {
-        assert.equal(plugin.filter('files.css'), true, 'files.css should be true');
-        assert.equal(plugin.filter('files.js'), false, 'files.js should be false');
-        assert.equal(plugin.filter('/.css/file'), false, '/.css/file should be false');
+        assert.strictEqual(plugin.filter('files.css'), true, 'files.css should be true');
+        assert.strictEqual(plugin.filter('files.js'), false, 'files.js should be false');
+        assert.strictEqual(plugin.filter('/.css/file'), false, '/.css/file should be false');
     }
 
     it('default', function() {
@@ -21,18 +21,18 @@ describe('Constructor', function() {
     it('with options', function() {
         const options = { test: 1 };
         const plugin = new CssoWebpackPlugin(options);
-        assert.deepEqual(plugin.options, { test: 1 }, 'single argument with options');
-        assert.deepEqual(options, { test: 1 }, 'single argument with options immutable');
+        assert.deepStrictEqual(plugin.options, { test: 1 }, 'single argument with options');
+        assert.deepStrictEqual(options, { test: 1 }, 'single argument with options immutable');
         testDefaultFilter(plugin);
     });
 
     it('with regexp filter', function() {
         const plugin = new CssoWebpackPlugin(/^text/gi);
 
         testDefaultOptions(plugin);
-        assert.equal(plugin.filter('text-file.pcss'), true, 'text-file.pcss should be true');
-        assert.equal(plugin.filter('files.js'), false, 'files.js should be false');
-        assert.equal(plugin.filter('/.css/text'), false, '/.css/text should be false');
+        assert.strictEqual(plugin.filter('text-file.pcss'), true, 'text-file.pcss should be true');
+        assert.strictEqual(plugin.filter('files.js'), false, 'files.js should be false');
+        assert.strictEqual(plugin.filter('/.css/text'), false, '/.css/text should be false');
 
         assert.doesNotThrow(
             function() { new CssoWebpackPlugin({}, /^text/gi); },
@@ -45,10 +45,10 @@ describe('Constructor', function() {
 
         const oneArgPlugin = new CssoWebpackPlugin(filter);
         testDefaultOptions(oneArgPlugin);
-        assert.equal(oneArgPlugin.filter, filter, 'single `filter` should be set to this.filter');
+        assert.strictEqual(oneArgPlugin.filter, filter, 'single `filter` should be set to this.filter');
 
         const twoArgPlugin = new CssoWebpackPlugin({}, filter);
-        assert.equal(twoArgPlugin.filter, filter, 'second argument `filter` should be set to this.filter');
+        assert.strictEqual(twoArgPlugin.filter, filter, 'second argument `filter` should be set to this.filter');
     });
 
     it('unexpected type for filter', function() {

test/webpack2/integrations.spec.js

@@ -0,0 +1,5 @@
+const runIntegrations = require('../lib/integrations.js');
+
+describe('Integrations with webpack 2', function() {
+    runIntegrations.call(this, __dirname, '2');
+});

test/webpack2/package.json

@@ -0,0 +1,7 @@
+{
+  "dependencies": {
+    "css-loader": "^0.28.11",
+    "extract-text-webpack-plugin": "^2.1.0",
+    "webpack": "^2.7.0"
+  }
+}

test/webpack.config.js → test/webpack2/webpack.config.js

@@ -1,5 +1,5 @@
-const DefinePlugin = require('webpack').DefinePlugin;
-const ExtractTextPlugin = require('extract-text-webpack-plugin');
+const DefinePlugin = require('./node_modules/webpack').DefinePlugin;
+const ExtractTextPlugin = require('./node_modules/extract-text-webpack-plugin');
 
 const styleExtractPlugin = new ExtractTextPlugin({
     filename: '[name].css',
@@ -24,7 +24,7 @@ module.exports = function (options) {
                     test: /\.css$/,
                     use: ExtractTextPlugin.extract({
                         use: {
-                            loader: 'css-loader',
+                            loader: options.basePath + '/node_modules/css-loader',
                             options: {
                                 modules: true,
                                 localIdentName: 'local-[local]',

test/webpack4/integrations.spec.js

@@ -0,0 +1,5 @@
+const runIntegrations = require('../lib/integrations.js');
+
+describe('Integrations with webpack 4', function() {
+    runIntegrations.call(this, __dirname, '4');
+});

test/webpack4/package.json

@@ -0,0 +1,7 @@
+{
+  "dependencies": {
+    "css-loader": "^5.2.0",
+    "mini-css-extract-plugin": "^1.4.0",
+    "webpack": "^4.46.0"
+  }
+}

test/webpack4/webpack.config.js

@@ -0,0 +1,47 @@
+const DefinePlugin = require('webpack').DefinePlugin;
+const ExtractTextPlugin = require('mini-css-extract-plugin');
+
+const styleExtractPlugin = new ExtractTextPlugin({
+    filename: '[name].css',
+});
+
+module.exports = function (options) {
+    return {
+        mode: 'none',
+        entry: {
+            test: './index.js'
+        },
+        cache: false,
+        performance: false,
+        context: options.testDirectory,
+        output: {
+            filename: '[name].js',
+            path: options.outputDirectory,
+        },
+        module: {
+            rules: [
+                {
+                    test: /\.css$/,
+                    use: [
+                        ExtractTextPlugin.loader,
+                        {
+                            loader: options.basePath + '/node_modules/css-loader',
+                            options: {
+                                modules: {
+                                    localIdentName: 'local-[local]',
+                                },
+                                sourceMap: true
+                            }
+                        },
+                    ],
+                },
+            ],
+        },
+        plugins: [
+            new DefinePlugin({
+                'process.env.NODE_ENV': '"production"',
+            }),
+            styleExtractPlugin,
+        ],
+    };
+};