Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise ZA relevant language entries #6732

Closed
wants to merge 1 commit into from
Closed

Revise ZA relevant language entries #6732

wants to merge 1 commit into from

Conversation

lcjohnso
Copy link
Member

@lcjohnso lcjohnso commented Jul 20, 2023

Staging branch URL: https://pr-6732.pfe-preview.zooniverse.org

Matching zooniverse/pandora#661, update language entries relevant to South Africa, taking the following actions

  • Remove duplicate entries.
  • Make all -za entries general by removing country specification (non-specific versions were missing before).
  • Edit labels for ZA-relevant entries to include standard/reference language name (matching ISO language name) and local names separated by "/" character. e.g., for xh, "Xhosa / isiXhosa"

Surpasses and replaces #6731.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@lcjohnso lcjohnso requested a review from eatyourgreens July 20, 2023 20:51
@lcjohnso lcjohnso mentioned this pull request Jul 20, 2023
18 tasks
@coveralls
Copy link

Coverage Status

coverage: 57.233%. remained the same when pulling 630308c on za-lang-edit into eda3339 on master.

@@ -77,6 +75,7 @@ const languages = [
{ value: 'moh-ca', label: 'Mohawk (Mohawk)' },
{ value: 'mn', label: 'Mongolian' },
{ value: 'ne-np', label: 'Nepali (Nepal)' },
{ value: 'nso', label: 'Northern Sotho / Sesotho sa Leboa' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please not use colonial names?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I wrote in the PR text, I'm opting to include both the official ISO Language Name and the local/native name. Including both names is useful -- it resolves possible confusion in the case of "Sesotho" -- Sesotho = Southern Sotho = st vs. Sesotho sa Leboa = Northern Sotho = nso.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ISO name is not official. Can we use the names that we’ve been asked to use by people who speak these languages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, ‘native name’????

Copy link
Contributor

@eatyourgreens eatyourgreens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the language names that we’ve been given by our colleagues in South Africa?

@lcjohnso lcjohnso requested a review from eatyourgreens July 20, 2023 21:03
@eatyourgreens
Copy link
Contributor

eatyourgreens commented Jul 21, 2023

Here's the list of languages that we've been given:

  • isiXhosa
  • Sesotho
  • Tshivenḓa
  • Xitsonga
  • isiZulu

If we could stick with those names, that would be great. If we must add the European names too, then we could maybe do something like 'Xitsonga / Tsonga' but I'm not sure what value the European names add to the project builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants