-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise ZA relevant language entries #6732
Conversation
@@ -77,6 +75,7 @@ const languages = [ | |||
{ value: 'moh-ca', label: 'Mohawk (Mohawk)' }, | |||
{ value: 'mn', label: 'Mongolian' }, | |||
{ value: 'ne-np', label: 'Nepali (Nepal)' }, | |||
{ value: 'nso', label: 'Northern Sotho / Sesotho sa Leboa' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please not use colonial names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I wrote in the PR text, I'm opting to include both the official ISO Language Name and the local/native name. Including both names is useful -- it resolves possible confusion in the case of "Sesotho" -- Sesotho = Southern Sotho = st
vs. Sesotho sa Leboa = Northern Sotho = nso
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ISO name is not official. Can we use the names that we’ve been asked to use by people who speak these languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, ‘native name’????
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the language names that we’ve been given by our colleagues in South Africa?
Here's the list of languages that we've been given:
If we could stick with those names, that would be great. If we must add the European names too, then we could maybe do something like 'Xitsonga / Tsonga' but I'm not sure what value the European names add to the project builder. |
Staging branch URL: https://pr-6732.pfe-preview.zooniverse.org
Matching zooniverse/pandora#661, update language entries relevant to South Africa, taking the following actions
-za
entries general by removing country specification (non-specific versions were missing before).xh
, "Xhosa / isiXhosa"Surpasses and replaces #6731.
Required Manual Testing
Review Checklist
npm ci
and app works as expected?Optional
ChangeListener
orPromiseRenderer
components with code that updates component state?