Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: preview API client fixes for Talk searches #7071

Closed

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Apr 2, 2024

Installs a version of the API client that shouldn't crash when a
response contains null items.

Staging branch URL: https://pr-7071.pfe-preview.zooniverse.org/talk/search?query=depression&env=production

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

Installs a version of the API client that shouldn't crash when a
response contains `null` items.
@coveralls
Copy link

Coverage Status

coverage: 56.959% (-0.02%) from 56.98%
when pulling ba71f75 on eatyourgreens:talk-null-comments
into 42cd979 on zooniverse:master.

@eatyourgreens eatyourgreens deleted the talk-null-comments branch April 11, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants